You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a little rough -- we need more testing. But it should work. Followed the spec at it was fairly clean -- using typed dicts, and validating on decoration. Also restricting to only primitives -- we can change it later but I want to keep things a lot simpler for now.
[Short description explaining the high-level reason for the pull request]
Changes
How I tested this
Notes
Checklist
PR has an informative and human-readable title (this will be pulled into the release notes)
Changes are limited to a single goal (no scope creep)
Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
Any change in functionality is tested
New functions are documented (with a description, list of inputs, and expected output)
Placeholder code is flagged / future TODOs are captured in comments
Project documentation has been updated if adding/changing functionality.
Issue by elijahbenizzy
Sunday Jan 15, 2023 at 07:16 GMT
Originally opened as stitchfix/hamilton#277
stitchfix/hamilton#276
This is a little rough -- we need more testing. But it should work. Followed the spec at it was fairly clean -- using typed dicts, and validating on decoration. Also restricting to only primitives -- we can change it later but I want to keep things a lot simpler for now.
[Short description explaining the high-level reason for the pull request]
Changes
How I tested this
Notes
Checklist
elijahbenizzy included the following code: https://github.com/stitchfix/hamilton/pull/277/commits
The text was updated successfully, but these errors were encountered: