Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype for typed_tag. Solve #63

Closed
7 tasks
HamiltonRepoMigrationBot opened this issue Feb 26, 2023 · 1 comment
Closed
7 tasks

Prototype for typed_tag. Solve #63

HamiltonRepoMigrationBot opened this issue Feb 26, 2023 · 1 comment
Labels
migrated-from-old-repo Migrated from old repository

Comments

@HamiltonRepoMigrationBot
Copy link
Collaborator

Issue by elijahbenizzy
Sunday Jan 15, 2023 at 07:16 GMT
Originally opened as stitchfix/hamilton#277


stitchfix/hamilton#276

This is a little rough -- we need more testing. But it should work. Followed the spec at it was fairly clean -- using typed dicts, and validating on decoration. Also restricting to only primitives -- we can change it later but I want to keep things a lot simpler for now.

[Short description explaining the high-level reason for the pull request]

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

elijahbenizzy included the following code: https://github.com/stitchfix/hamilton/pull/277/commits

@elijahbenizzy elijahbenizzy added the migrated-from-old-repo Migrated from old repository label Feb 26, 2023
@elijahbenizzy
Copy link
Collaborator

Old PR, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migrated-from-old-repo Migrated from old repository
Projects
None yet
Development

No branches or pull requests

2 participants