Merge pull request #51 from CruGlobal/delete_old_products

Delete products that are no longer in Woo

Author: jbirdjavi

app/services/woo_refresh.rb

@@ -103,6 +103,8 @@ def handle_job job
 
   def save_products_to_db job, products
     log job, "Found #{products.count} products. Saving to database."
+    existing_products = WooProduct.all.to_a
+
     products.each do |product|
       woo_product = WooProduct.find_or_create_by(product_id: product["id"])
       woo_product.sku = product["sku"]
@@ -116,8 +118,14 @@ def save_products_to_db job, products
           wbi.save!
         end
       end
+      existing_products.delete(woo_product)
       log job, "Saved product #{woo_product.product_id} with sku #{woo_product.sku}. Bundle count: #{product["bundled_items"].count}"
     end
+
+    existing_products.each do |product|
+      product.destroy
+      log job, "Deleted product #{product.product_id}"
+    end
   rescue => e
     log job, "Error saving products to database: #{e.message}"
     job.status_error!

spec/services/woo_refresh_spec.rb

@@ -38,14 +38,25 @@
   end
 
   it("it should save products to the db") do
-    allow(woo).to receive(:get_page).and_return([{"id" => 1, "name" => "Test Product", "price" => "10.00", "sku" => "12345", "description" => "Test Description", "categories" => [{"id" => 1, "name" => "Test Category"}]}])
+    allow(woo).to receive(:get_page).and_return([{"id" => 1, "name" => "Test Product", "price" => "10.00", "sku" => "12345", "description" => "Test Description", "bundled_items" => [], "categories" => [{"id" => 1, "name" => "Test Category"}]}])
 
     job = woo.create_job
     products = woo.get_page job, 1, {status: "publish", per_page: 1, page: 1}
     woo.save_products_to_db job, products
     expect(WooProduct.count).to be > 0
   end
 
+  it "should delete products that are no longer in woo" do
+    allow(woo).to receive(:get_page).and_return([{"id" => 1, "name" => "Test Product", "price" => "10.00", "sku" => "12345", "description" => "Test Description", "bundled_items" => [], "categories" => [{"id" => 1, "name" => "Test Category"}]}])
+    create(:woo_product, product_id: 30)
+
+    job = woo.create_job
+    products = woo.get_page job, 1, {status: "publish", per_page: 1, page: 1}
+    woo.save_products_to_db job, products
+    expect(WooProduct.count).to eq(1)
+    expect(WooProduct.find_by(product_id: 30)).to be_nil
+  end
+
   it("it should handle a job") do
     job = woo.create_job
     woo.handle_job job