Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trouble viewing example #123

Open
MartinBarker opened this issue Oct 25, 2022 · 0 comments
Open

trouble viewing example #123

MartinBarker opened this issue Oct 25, 2022 · 0 comments

Comments

@MartinBarker
Copy link

  • i cloned the repo, cd'd into the examples folder, and ran npm i which reuslts in errors because of the 'link' elements in package.json (i am running on windows subsystem linux) if i remove the 'link' lines, running the app with 'npm start' just errors out.
  • I have a pre-existing electron react app here: https://github.com/MartinBarker/electron-react
    i tried following the instructions in this repo's readme to install the package, add it to my electron.js file, and add the frameless window into my App.js file, with some minor edits, but it has been failing with different errors such as this:
[0] ERROR in ./node_modules/electron/index.js 1:11-24
[0] Module not found: Error: Can't resolve 'fs' in 'C:\Users\martin\Documents\projects\electron-react\node_modules\electron'
[0] resolve 'fs' in 'C:\Users\martin\Documents\projects\electron-react\node_modules\electron'
[0]   Parsed request is a module
[0]   using description file: C:\Users\martin\Documents\projects\electron-react\node_modules\electron\package.json (relative path: .)
[0]     Field 'browser' doesn't contain a valid alias configuration
[0]     resolve as module
[0]       looking for modules in C:\Users\martin\Documents\projects\electron-react\node_modules\electron\node_modules
[0]         single file module
[0]           using description file: C:\Users\martin\Documents\projects\electron-react\node_modules\electron\package.json (relative path: ./node_modules/fs)        
[0]             no extension
[0]               Field 'browser' doesn't contain a valid alias configuration
[0]               C:\Users\martin\Documents\projects\electron-react\node_modules\electron\node_modules\fs doesn't exist
[0]             .web.mjs
[0]               Field 'browser' doesn't contain a valid alias configuration
[0]               C:\Users\martin\Documents\projects\electron-react\node_modules\electron\node_modules\fs.web.mjs doesn't exist
[0]             .mjs

Could you help me add this frameless window feature to my app https://github.com/MartinBarker/electron-react ? I would really love to see it in action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant