Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract correct amount of fluids form Layered Cauldrons #6506

Conversation

Attack8
Copy link
Contributor

@Attack8 Attack8 commented May 19, 2024

@TropheusJ
Copy link
Collaborator

this will both delete and duplicate fluids since 1 bottle is equal to both 1/3rd of a bucket (333.333... mb) and 250mb depending on context

@Attack8
Copy link
Contributor Author

Attack8 commented May 19, 2024

Yea, I’m not sure what’s up with bottled fluids. This seemed like a decent resolution but absolutely not perfect

@TropheusJ
Copy link
Collaborator

I think it would be best for only full cauldrons to work

@MrRedstoneToGo
Copy link

this will both delete and duplicate fluids since 1 bottle is equal to both 1/3rd of a bucket (333.333... mb) and 250mb depending on context

How about we change the spouting/filling recipes for potions/water bottles to 333 1/3 mB or give the cauldron a fourth layer?

@IThundxr
Copy link
Collaborator

full cauldrons is the best fix here, modifying recipes like that shouldn't be done

@IThundxr IThundxr added pr type: fix PR fixes a bug pr flag: simple PR has minimal changes labels May 19, 2024
@Attack8
Copy link
Contributor Author

Attack8 commented May 19, 2024

Ok, I’ll make sure it checks for a full cauldron then

@TropheusJ
Copy link
Collaborator

dealing with thirds of buckets/millibuckets is a non-starter since it has to delete/dupe. Adding a 4th layer to cauldrons is insane and will break everything.

@MrRedstoneToGo
Copy link

MrRedstoneToGo commented May 19, 2024

I almost thought so. Another thing: If only water cauldrons extend LayeredCauldronBlock, then the Amendments bug is not fixed, on the other hand, if Liquid Cauldrons (Admentmends) extend LayeredCauldronBlock, the bug with Admensments is not fixed either, because the pump would always pull water.

simibubi added a commit that referenced this pull request Jul 16, 2024
- Partially filled water cauldrons can no longer be drained by fluid pipes #6506 #6505
- Fixed forge capabilities on modded cauldron blocks getting ignored (?)
@simibubi
Copy link
Collaborator

Thank you for the PR.
The water cauldron has been addressed in a commit.
I don't see any solution here that addresses the compatibility issue that was linked.

After a quick look, the issue with amendments remains unsolved. Since my commit, the capability they implemented does get recognised, however the create pipes don't seem to be able to gradually pull the liquid out.

@simibubi simibubi closed this Jul 16, 2024
@Attack8 Attack8 deleted the mc1.18/cauldron-extraction branch July 17, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr flag: simple PR has minimal changes pr type: fix PR fixes a bug
Projects
None yet
5 participants