Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix items being voided when transferring between basins #6474

Closed
wants to merge 1 commit into from
Closed

Fix items being voided when transferring between basins #6474

wants to merge 1 commit into from

Conversation

Attack8
Copy link
Contributor

@Attack8 Attack8 commented May 11, 2024

fixes #6451

@IThundxr IThundxr added pr type: fix PR fixes a bug pr flag: simple PR has minimal changes labels May 11, 2024
simibubi added a commit that referenced this pull request Jul 16, 2024
@simibubi
Baiting the hotfix
661e5c5 
- Fixed basin inventory pretending to accept full stacks when empty #3104
- Fixed basin spout outputs getting voided when targeting another basin #6451 #6474
- Fixed basin spout outputs not working when targeting a basin with a recipe filter
@simibubi
Copy link
Collaborator

Thanks for the PR.
This issue was caused by an underlying bug in basin inventories, which has been resolved in a commit

@simibubi simibubi closed this Jul 16, 2024
@Attack8 Attack8 deleted the mc1.18/basinvoidfix branch July 17, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr flag: simple PR has minimal changes pr type: fix PR fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Basin voiding excess items when another basin placed beneath
3 participants
@Attack8 @simibubi @IThundxr