Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do you think it is possible to add support for downloading the qr with an icon that has been entered with url? #260

Closed
DIKGONZA opened this issue Aug 21, 2024 · 2 comments · Fixed by #264
Closed

Do you think it is possible to add support for downloading the qr with an icon that has been entered with url? #260

DIKGONZA opened this issue Aug 21, 2024 · 2 comments · Fixed by #264
Assignees
@Cordobo
Milestone
18.x

Comments

@DIKGONZA
Copy link

DIKGONZA commented Aug 21, 2024 •
edited
Loading

It only allows to download if the image is in the project assets, but if you put the image with a url it doesn't download it.

image

https://stackblitz.com/edit/stackblitz-starters-dy21ym?file=src%2Fmain.ts

Thanks you
@amazing4u amazing4u mentioned this issue Sep 29, 2024
Merged
@amazing4u
Copy link
Contributor

@DIKGONZA @Cordobo I fixed this and created a pull request for this

Cordobo added a commit that referenced this issue Sep 29, 2024
@Cordobo
Merge pull request #264 from amazing4u/main
9373b40 
fix #260: allow download canvas with embedded images from other origins
@Cordobo Cordobo self-assigned this Sep 29, 2024
@Cordobo Cordobo added this to the 18.x milestone Sep 29, 2024
@Cordobo
Copy link
Owner

Cordobo commented Sep 29, 2024

Merged and released as 18.0.2

@amazing4u thanks for the pull request 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cordobo Cordobo

Labels
None yet
Projects
None yet
Milestone
18.x
Development

Successfully merging a pull request may close this issue.

fix #260: allow download canvas with embedded images from other origins amazing4u/angularx-qrcode
3 participants
@Cordobo @amazing4u @DIKGONZA