Skip to content

Scale-dependent slope fails #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pastewka opened this issue Oct 19, 2021 · 12 comments
Closed

Scale-dependent slope fails #739

pastewka opened this issue Oct 19, 2021 · 12 comments
Labels
bug Something isn't working
Milestone

Comments

@pastewka
Copy link
Contributor

This is for https://contact.engineering/go/867nv/

image

@pastewka pastewka added the bug Something isn't working label Oct 19, 2021
@pastewka pastewka added this to the v0.16.1 milestone Oct 19, 2021
@mcrot
Copy link
Collaborator

mcrot commented Oct 19, 2021

I've also seen this for other functions. Duplicate of #737 .

@pastewka
Copy link
Contributor Author

Now I get this:

image

There are two error emails (Wed, 20 Oct 2021 07:47:18 -0000 (20.10.2021 09:47:18) and Wed, 20 Oct 2021 07:47:19 -0000 (20.10.2021 09:47:19)) associated with this error.

They contain the following traceback:

Traceback (most recent call last):
  File "/opt/conda/lib/python3.7/site-packages/django/core/handlers/exception.py", line 47, in inner
    response = get_response(request)
  File "/opt/conda/lib/python3.7/site-packages/django/core/handlers/base.py", line 181, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/opt/conda/lib/python3.7/contextlib.py", line 74, in inner
    return func(*args, **kwds)
  File "/opt/conda/lib/python3.7/site-packages/django/contrib/auth/decorators.py", line 21, in _wrapped_view
    return view_func(request, *args, **kwargs)
  File "/app/topobank/analysis/views.py", line 117, in switch_card_view
    return view_class.as_view()(request)
  File "/opt/conda/lib/python3.7/site-packages/django/views/generic/base.py", line 70, in view
    return self.dispatch(request, *args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/django/views/generic/base.py", line 98, in dispatch
    return handler(request, *args, **kwargs)
  File "/app/topobank/analysis/views.py", line 333, in post
    response = super().get(request, *args, **kwargs)
  File "/opt/conda/lib/python3.7/site-packages/django/views/generic/base.py", line 159, in get
    context = self.get_context_data(**kwargs)
  File "/app/topobank/analysis/views.py", line 740, in get_context_data
    labels=subject_checkbox_groups[topography_ct],

@mcrot
Copy link
Collaborator

mcrot commented Oct 20, 2021

Ah yes, it's a KeyError. The key <ContentType: manager | topography> is missing. I think that's not related to the error message with memcached, but should be easy to fix.

@pastewka
Copy link
Contributor Author

Is that a migration issue?

@mcrot
Copy link
Collaborator

mcrot commented Oct 20, 2021

No, I don't think so. There is a path in the code where a dictionary has not been set up properly.
More an issue of a missing test.

@pastewka
Copy link
Contributor Author

Sounds good!

@pastewka
Copy link
Contributor Author

For some surfaces the scale-dependent slope and curvature now shows correctly. Part of the problem may have simply been a memory issue on the server.

@mcrot
Copy link
Collaborator

mcrot commented Oct 22, 2021

Yes, I restarted all failed analyses yesterday. Another argument to switch to the new server with the next bugfix release.

@mcrot
Copy link
Collaborator

mcrot commented Oct 22, 2021

I confirm that the memcached errors don't occur if there is enough free memory.

@mcrot
Copy link
Collaborator

mcrot commented Oct 22, 2021

I've fixed the KeyError and close this with that commit.
The memcached error is also referenced by #737, which is still open.

@mcrot
Copy link
Collaborator

mcrot commented Oct 22, 2021

We should check whether the surface analyses fail if all underlying measurement analyses fail.
Those key errors are related to that case where there is a "successful" surface analysis, but later
no analyses are available for measurements. This special case is handled now.

@pastewka
Copy link
Contributor Author

I'll create an issue on the SurfaceTopography side for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants