Add support to builder validator registration using ssz #9065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfyone
reviewed
Jan 30, 2025
Comment on lines
206
to
254
| + " is not a supported milestone for the builder rest api. Milestones >= Bellatrix are supported.")); | ||
| + " is not a supported milestone for the builder rest api. Milestones >= Bellatrix are " | ||
| + "supported.")); |
There was a problem hiding this comment.
could be unchanged really...
rolfyone
reviewed
Jan 30, 2025
Comment on lines
312
to
315
| assertThat(mockWebServer.getRequestCount()).isEqualTo(3); | ||
| verifyPostRequestSsz("/eth/v1/builder/validators", signedValidatorRegistrations); | ||
| verifyPostRequestJson("/eth/v1/builder/validators", signedValidatorRegistrationsRequest); | ||
| verifyPostRequestSsz("/eth/v1/builder/validators", signedValidatorRegistrations); |
There was a problem hiding this comment.
nit: we should probably make a tiny change here to show that the first set are verified and the second set is just the ssz call... we basically show that with the asserts above but it'd be clearer if this last check is just seeing 1 request, and just ssz.
There was a problem hiding this comment.
I guess I can move the early assertions closer to where we exercise the request to make them a bit more "sequential".
tbenr
reviewed
Jan 31, 2025
Comment on lines
+135
to
+137
| } else { | ||
| return SafeFuture.completedFuture(response); | ||
| } |
There was a problem hiding this comment.
you could avoid else here ;-)
tbenr
reviewed
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Implement support for SSZ requests when registering validators via the Builder endpoint. Logic based on this spec ethereum/builder-specs#110.
Since we don't have a way to know if the relay supports SSZ, our best bet is to try SSZ and if it fails fallback into JSON. However, we do not want to keep trying SSZ for every request after a failure so we are adding a backoff logic (24h).
Fixed Issue(s)
fixes #9003
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog