feat: recognition of new precompile address for secp256r1 curve in TR… (#818)

In Osaka, a new precompile is added at address 0x100. TRM module now recognizes this address as a precompile.
As the address of this new precompile is not contiguous like the other ones, we've renamed the constant `MAX_PRC_ADDRESS` to `MAX_PRC_CONTIGUOUS_ADDRESS`

Author: amkCha

Makefile

@@ -28,6 +28,7 @@ CONSTANTS := constants/constants.lisp
 CONSTANTS_LONDON := constants/london/constants.zkasm
 CONSTANTS_CANCUN := constants/cancun/constants.zkasm
 CONSTANTS_PRAGUE := constants/prague/constants.zkasm
+CONSTANTS_OSAKA := constants/osaka/constants.zkasm
 
 EC_DATA_LONDON := ecdata/london
 
@@ -97,7 +98,8 @@ TABLES_LONDON := reftables/london/*.lisp
 TABLES_CANCUN := reftables/cancun/*.lisp
 TABLES_PRAGUE := reftables/prague/*.lisp
 
-TRM := trm/trm.zkasm
+TRM_LONDON := trm/trm_london.zkasm
+TRM_OSAKA := trm/trm_osaka.zkasm
 
 TXN_DATA_LONDON := txndata/london
 TXN_DATA_SHANGHAI := txndata/shanghai
@@ -129,7 +131,6 @@ ZKEVM_MODULES_COMMON := ${CONSTANTS} \
 		 ${SHAKIRA_DATA} \
 		 ${SHIFT} \
 		 ${STP} \
-		 ${TRM} \
 		 ${WCP}
 
 ZKEVM_MODULES_LONDON := ${ZKEVM_MODULES_COMMON} \
@@ -145,6 +146,7 @@ ZKEVM_MODULES_LONDON := ${ZKEVM_MODULES_COMMON} \
 		 ${OOB_LONDON} \
 		 ${RLP_TXN_LONDON} \
 		 ${RLP_TXN_RCPT_LONDON} \
+		 ${TRM_LONDON} \
 		 ${TXN_DATA_LONDON}
 
 
@@ -163,6 +165,7 @@ ZKEVM_MODULES_SHANGHAI := ${ZKEVM_MODULES_COMMON} \
 		 ${OOB_SHANGHAI} \
 		 ${RLP_TXN_LONDON} \
 		 ${RLP_TXN_RCPT_LONDON} \
+		 ${TRM_LONDON} \
 		 ${TXN_DATA_SHANGHAI}
 
 ZKEVM_MODULES_CANCUN := ${ZKEVM_MODULES_COMMON} \
@@ -180,6 +183,7 @@ ZKEVM_MODULES_CANCUN := ${ZKEVM_MODULES_COMMON} \
 		 ${RLP_TXN_CANCUN} \
 		 ${RLP_TXN_RCPT_LONDON} \
 		 ${RLP_UTILS_CANCUN} \
+		 ${TRM_LONDON} \
 		 ${TXN_DATA_CANCUN}
 
 ZKEVM_MODULES_PRAGUE := ${ZKEVM_MODULES_COMMON} \
@@ -197,10 +201,11 @@ ZKEVM_MODULES_PRAGUE := ${ZKEVM_MODULES_COMMON} \
 		 ${RLP_TXN_PRAGUE} \
 		 ${RLP_TXN_RCPT_LONDON} \
 		 ${RLP_UTILS_CANCUN} \
+		 ${TRM_LONDON} \
 		 ${TXN_DATA_PRAGUE}
 
 ZKEVM_MODULES_OSAKA := ${ZKEVM_MODULES_COMMON} \
-		 ${CONSTANTS_PRAGUE} \
+		 ${CONSTANTS_OSAKA} \
 		 ${TABLES_PRAGUE} \
 		 ${BLOCKDATA_CANCUN} \
 		 ${BLS_PRAGUE} \
@@ -214,6 +219,7 @@ ZKEVM_MODULES_OSAKA := ${ZKEVM_MODULES_COMMON} \
 		 ${RLP_TXN_PRAGUE} \
 		 ${RLP_TXN_RCPT_OSAKA} \
 		 ${RLP_UTILS_CANCUN} \
+		 ${TRM_OSAKA} \
 		 ${TXN_DATA_OSAKA}
 
 all: zkevm_london.bin zkevm_paris.bin zkevm_shanghai.bin zkevm_cancun.bin zkevm_prague.bin zkevm_osaka.bin

constants/cancun/constants.zkasm

@@ -1 +1 @@
-const MAX_PRC_ADDRESS = 0x0a
+const MAX_PRC_CONTIGUOUS_ADDRESS = 0x0a

constants/london/constants.zkasm

@@ -1 +1 @@
-const MAX_PRC_ADDRESS = 0x09
+const MAX_PRC_CONTIGUOUS_ADDRESS = 0x09

constants/osaka/constants.zkasm

@@ -0,0 +1,3 @@
+const MAX_PRC_CONTIGUOUS_ADDRESS = 0x11
+;; this constant will be used once issue in go-corset is fixed https://github.com/Consensys/go-corset/issues/1284
+const P256_VERIFY_ADDRESS = 0x100

constants/prague/constants.zkasm

@@ -1 +1 @@
-const MAX_PRC_ADDRESS = 0x11
+const MAX_PRC_CONTIGUOUS_ADDRESS = 0x11

trm/trm.zkasm renamed to trm/trm_london.zkasm

@@ -17,6 +17,9 @@
 ;;
 ;; NOTE: the function currently only returns the high word of the
 ;; trimmed address, since the low word is unchanged.
+;; NOTE2: once issue is fixed in go-corset, we will be able to
+;; recombine trm_london and trm_osaka
+;; https://github.com/Consensys/go-corset/issues/1284
 pub fn trm(RAW_ADDRESS u256) -> (ADDRESS_HI u32, IS_PRECOMPILE u1) {
   var low, tmp u128
   var high u96
@@ -27,8 +30,8 @@ pub fn trm(RAW_ADDRESS u256) -> (ADDRESS_HI u32, IS_PRECOMPILE u1) {
   if ADDRESS_HI != 0 goto exit_0
   ;; discount address 0
   if low == 0 goto exit_0
-  ;; determine low <= MAX_PRC_ADDRESS
-  b,tmp = low - MAX_PRC_ADDRESS - 1
+  ;; determine low <= MAX_PRC_CONTIGUOUS_ADDRESS
+  b,tmp = low - MAX_PRC_CONTIGUOUS_ADDRESS - 1
   ;; done
   IS_PRECOMPILE=b
   return

trm/trm_osaka.zkasm

@@ -0,0 +1,49 @@
+;; The address trimming module does two things: (i) reduce 256bit
+;; addresses into u160 addresses (i.e. modulo 2^160); (b) identify
+;; addresses of precompiles : {0x1, 0x2 ... 0x11} U {0x100}
+;;
+;; The need for this function arises as some EVM opcodes take an u256
+;; stack argument requires trimming to be interpreted as an address.
+;; Likewise, when computing a deployment address associated with an
+;; invocation of a CREATE-type, the raw KECCAK hash must be trimmed.
+;;
+;; The following opcodes may trigger it:
+;;
+;; * BALANCE
+;; * EXTCODESIZE / EXTCODECOPY / EXTCODEHASH
+;; * CALL / CALLCODE / STATICCALL
+;; * SELFDESTRUCT
+;; * DELEGATECALL
+;;
+;; NOTE: the function currently only returns the high word of the
+;; trimmed address, since the low word is unchanged.
+;; NOTE2: once issue is fixed in go-corset, we will be able to
+;; recombine trm_london and trm_osaka by adding a
+;; P256_VERIFY_ADDRESS constant on all forks prior to Osaka
+;; whose value will be an already verified prc address
+;; https://github.com/Consensys/go-corset/issues/1284
+pub fn trm(RAW_ADDRESS u256) -> (ADDRESS_HI u32, IS_PRECOMPILE u1) {
+  var low, tmp u128
+  var high u96
+  var b1 u1
+  ;; trim off most significant 96 bytes
+  high,ADDRESS_HI,low = RAW_ADDRESS
+  ;; if hi word not zero, cannot be precompile.
+  if ADDRESS_HI != 0 goto exit_0
+  ;; discount address 0
+  if low == 0 goto exit_0
+  ;; determine low <= MAX_PRC_CONTIGUOUS_ADDRESS
+  b1,tmp = low - MAX_PRC_CONTIGUOUS_ADDRESS - 1
+  ;; if not, check low is P256_VERIFY_ADDRESS
+  if b1 == 0 goto check_p256_verify
+  ;; done
+  IS_PRECOMPILE=1
+  return
+check_p256_verify:
+   IS_PRECOMPILE = low == 0x100 ? 1 : 0
+   return
+exit_0:
+  ;; no, not precompile
+  IS_PRECOMPILE=0
+  return
+}