Fix asserts when dispatch excluded targets with pending compilation (reactorlabs#1211)

* Fix asserts when dispatch excluded targets with pending compilation

Author: JanJecmen

rir/src/api.cpp

@@ -330,7 +330,9 @@ SEXP pirCompile(SEXP what, const Context& assumptions, const std::string& name,
                     auto body = BODY(cls);
                     auto dt = DispatchTable::unpack(body);
                     if (dt->contains(c->context())) {
-                        auto other = dt->dispatch(c->context());
+                        // Dispatch also to versions with pending compilation
+                        // since we're not evaluating
+                        auto other = dt->dispatch(c->context(), false);
                         assert(other != dt->baseline());
                         assert(other->context() == c->context());
                         if (other->body()->isCompiled())

rir/src/runtime/Code.h

@@ -107,10 +107,7 @@ struct Code : public RirRuntimeObject<Code, CODE_MAGIC> {
         return lazyCompile();
     }
 
-    bool isCompiled() const {
-        return kind == Kind::Native && *lazyCodeHandle_ != '\0' &&
-               nativeCode_ != nullptr;
-    }
+    bool isCompiled() const { return kind == Kind::Native && nativeCode_; }
     // For Kind::Native there is an in-between state when the Code is already
     // placed in a Function but its code handle isn't yet filled by the
     // finalizer of PirJitLLVM. We need to prevent such instances from being

rir/src/runtime/DispatchTable.h

@@ -40,7 +40,7 @@ struct DispatchTable
         return f;
     }
 
-    Function* dispatch(Context a) const {
+    Function* dispatch(Context a, bool ignorePending = true) const {
         if (!a.smaller(userDefinedContext_)) {
 #ifdef DEBUG_DISPATCH
             std::cout << "DISPATCH trying: " << a
@@ -56,7 +56,7 @@ struct DispatchTable
 #endif
             auto e = get(i);
             if (a.smaller(e->context()) && !e->disabled() &&
-                !e->pendingCompilation())
+                (ignorePending || !e->pendingCompilation()))
                 return e;
         }
         return baseline();