Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cylinder creation disalignment #374

Open
JansenSmith opened this issue Jul 24, 2023 · 1 comment
Open

Cylinder creation disalignment #374

JansenSmith opened this issue Jul 24, 2023 · 1 comment
Assignees
Labels

Comments

@JansenSmith
Copy link
Member

using code
// make a gently rounded cylinder
CSG top = new RoundedCylinder(radius,height)
.cornerRadius(10)// sets the radius of the corner
.toCSG()// converts it to a CSG tor display

// make a subtly rounded cylinder
CSG bottom = new RoundedCylinder(radius,height/2)
.cornerRadius(2)// sets the radius of the corner
.toCSG()// converts it to a CSG tor display

// union the two
CSG body = top.union(bottom)

Expected Outcome:
Two aligned and analogous rounded cylinders with no seam.

Actual Outcome:
Two cylinders that don't mesh well and have a seam:
image

see: Halloween2020TheChild/Zoltar@8fe8117#diff-e30852a13801f01807cb22b62a8344799a3d9137a43768a1acc639499032ba26

@madhephaestus
Copy link
Member

I suspect the stair-step method for creating the cylendars is not correctly calculating the largest cylendars radius. This would be in JCSG, i think @JansenSmith should be able to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants