Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Cut Pro Trial has a different menu bar item #3368

Closed
latenitefilms opened this issue Aug 24, 2024 · 0 comments · Fixed by #3391
Closed

Final Cut Pro Trial has a different menu bar item #3368

latenitefilms opened this issue Aug 24, 2024 · 0 comments · Fixed by #3391
Assignees
Labels
Milestone

Comments

@latenitefilms
Copy link
Contributor

I think we have a bunch of "Final Cut Pro" hardcoded in various menu bar sections of the code. Opps.

image
	...lity Helper.app/Contents/Resources/extensions/hs/ipc.lua:420: in function 'hs.libipc.__defaultHandler'
2024-08-24 14:26:31: 14:26:31     jumper:     [Jumper] Notification handler triggered: hs.notify: Unassigned Keyboard Command (0x60000192f6b8)
2024-08-24 14:26:31:                          [Jumper] Notification Activation Type: 2
2024-08-24 14:26:32: ...app/Contents/Resources/extensions/cp/rx/go/Statement.lua:134: Unable to find 'Final Cut Pro' in 'Final Cut Pro Trial' while in 'en'.
stack traceback:
	...app/Contents/Resources/extensions/cp/rx/go/Statement.lua:134: in upvalue 'fn'
	...r.app/Contents/Resources/extensions/cp/rx/Observable.lua:268: in method 'subscribe'
	...r.app/Contents/Resources/extensions/cp/rx/Observable.lua:3077: in function <...r.app/Contents/Resources/extensions/cp/rx/Observable.lua:2996>
	(...tail calls...)
	...r.app/Contents/Resources/extensions/cp/rx/Observable.lua:1532: in field '_onNext'
	...per.app/Contents/Resources/extensions/cp/rx/Observer.lua:60: in function 'cp.rx.Observer.onNext'
	(...tail calls...)
	... Helper.app/Contents/Resources/extensions/cp/rx/util.lua:21: in function <... Helper.app/Contents/Resources/extensions/cp/rx/util.lua:21>
	[C]: in function 'xpcall'
	... Helper.app/Contents/Resources/extensions/cp/rx/util.lua:21: in function 'cp.rx.util.tryWithObserver'
	...r.app/Contents/Resources/extensions/cp/rx/Observable.lua:1631: in field '_onNext'
	...per.app/Contents/Resources/extensions/cp/rx/Observer.lua:60: in function 'cp.rx.Observer.onNext'
	...	(skipping 90 levels)
	...r.app/Contents/Resources/extensions/cp/rx/Observable.lua:2854: in function <...r.app/Contents/Resources/extensions/cp/rx/Observable.lua:2779>
	(...tail calls...)
	...r.app/Contents/Resources/extensions/cp/rx/Observable.lua:977: in function <...r.app/Contents/Resources/extensions/cp/rx/Observable.lua:964>
	(...tail calls...)
	...r.app/Contents/Resources/extensions/cp/rx/Observable.lua:1382: in function <...r.app/Contents/Resources/extensions/cp/rx/Observable.lua:1349>
	(...tail calls...)
	...r.app/Contents/Resources/extensions/cp/rx/Observable.lua:1654: in function <...r.app/Contents/Resources/extensions/cp/rx/Observable.lua:1617>
	(...tail calls...)
	...r.app/Contents/Resources/extensions/cp/rx/Observable.lua:1205: in function <...r.app/Contents/Resources/extensions/cp/rx/Observable.lua:1167>
	(...tail calls...)
	...r.app/Contents/Resources/extensions/cp/rx/Observable.lua:3077: in function <...r.app/Contents/Resources/extensions/cp/rx/Observable.lua:2996>
	(...tail calls...)
	...r.app/Contents/Resources/extensions/cp/rx/Observable.lua:3077: in function <...r.app/Contents/Resources/extensions/cp/rx/Observable.lua:2996>
	(...tail calls...)
	...r.app/Contents/Resources/extensions/cp/rx/Observable.lua:1654: in function <...r.app/Contents/Resources/extensions/cp/rx/Observable.lua:1617>
	(...tail calls...)
	...app/Contents/Resources/extensions/cp/rx/go/Statement.lua:651: in method 'Now'
	...Helper.app/Contents/Resources/extensions/jumper/init.lua:368: in field 'integer index'
	...y Helper.app/Contents/Resources/extensions/hs/notify.lua:125: in function 'hs.libnotify._tag_handler'
@latenitefilms latenitefilms added this to the 1.4.28 milestone Aug 24, 2024
@latenitefilms latenitefilms self-assigned this Aug 24, 2024
latenitefilms added a commit that referenced this issue Nov 17, 2024
- This fixes menubar actions for Final Cut Pro Trial users.
- Closes #3368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant