Test compare function.

Author: robinjhuang

src/validate_nodes.py

@@ -104,37 +104,6 @@ def compare_return_types(node_name: str, base_class: Type, pr_class: Type) -> li
 
     return changes
 
-def compare_input_types(node_name: str, base_class: Type, pr_class: Type) -> list[BreakingChange]:
-    """Compare INPUT_TYPES between base and PR versions of a node."""
-    changes = []
-    
-    base_inputs = base_class.INPUT_TYPES().get("required", {})
-    pr_inputs = pr_class.INPUT_TYPES().get("required", {})
-
-    # Check for removed inputs
-    for input_name, input_config in base_inputs.items():
-        if input_name not in pr_inputs:
-            changes.append(BreakingChange(
-                node_name=node_name,
-                change_type=BreakingChangeType.INPUT_REMOVED,
-                details=f"Required input '{input_name}' was removed",
-                base_value=input_config,
-                pr_value=None
-            ))
-            continue
-
-        # Check input type changes
-        if pr_inputs[input_name][0] != input_config[0]:
-            changes.append(BreakingChange(
-                node_name=node_name,
-                change_type=BreakingChangeType.INPUT_TYPE_CHANGED,
-                details=f"Input type changed for '{input_name}'",
-                base_value=input_config[0],
-                pr_value=pr_inputs[input_name][0]
-            ))
-
-    return changes
-
 def compare_function(node_name: str, base_class: Type, pr_class: Type) -> list[BreakingChange]:
     """Compare FUNCTION attribute between base and PR versions of a node."""
     changes = []
@@ -171,7 +140,6 @@ def compare_nodes(base_nodes: Dict[str, Type], pr_nodes: Dict[str, Type]) -> lis
         pr_class = pr_nodes[node_name]
 
         changes.extend(compare_return_types(node_name, base_class, pr_class))
-        changes.extend(compare_input_types(node_name, base_class, pr_class))
         changes.extend(compare_function(node_name, base_class, pr_class))
 
     return changes

tests/test_validate_nodes.py

@@ -58,3 +58,44 @@ def test_compare_return_types_missing():
     assert changes[0].change_type == BreakingChangeType.RETURN_TYPES_CHANGED
     assert changes[0].base_value == ("STRING", "INT", "FLOAT")
     assert changes[0].pr_value == tuple()
+
+
+def test_compare_function():
+    from src.validate_nodes import compare_function, BreakingChangeType
+
+    class BaseNode:
+        FUNCTION = "process"
+
+    class PRNode:
+        FUNCTION = "process"
+
+    class ChangedNode:
+        FUNCTION = "different_process"
+
+    class NoFunctionNode:
+        pass
+
+    # Test 1: No changes
+    changes = compare_function("TestNode", BaseNode, PRNode)
+    assert len(changes) == 0
+
+    # Test 2: Function changed
+    changes = compare_function("TestNode", BaseNode, ChangedNode)
+    assert len(changes) == 1
+    assert changes[0].change_type == BreakingChangeType.FUNCTION_CHANGED
+    assert changes[0].base_value == "process"
+    assert changes[0].pr_value == "different_process"
+
+    # Test 3: Function removed
+    changes = compare_function("TestNode", BaseNode, NoFunctionNode)
+    assert len(changes) == 1
+    assert changes[0].change_type == BreakingChangeType.FUNCTION_CHANGED
+    assert changes[0].base_value == "process"
+    assert changes[0].pr_value is None
+
+    # Test 4: Function added (not a breaking change if base had none)
+    changes = compare_function("TestNode", NoFunctionNode, BaseNode)
+    assert len(changes) == 1
+    assert changes[0].change_type == BreakingChangeType.FUNCTION_CHANGED
+    assert changes[0].base_value is None
+    assert changes[0].pr_value == "process"