Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple marks with the same key #54

Open
JohnRiv opened this issue Sep 19, 2016 · 0 comments
Open

Support multiple marks with the same key #54

JohnRiv opened this issue Sep 19, 2016 · 0 comments

Comments

@JohnRiv
Copy link
Member

JohnRiv commented Sep 19, 2016

Currently getMark returns the High Res mark if the browser supports User Timing instead of the User Timing mark. This is by design (user Timing is just for duration calculations), but results in overwriting values with the same key.

Need a way to have the same key used for multiple marks so we can maintain that User Timing feature if needed.

Related - for more accurate marks when the browser supports both High Res time and User Timing, we should grab the User Timing mark reference to startTime and store that as the high-res mark instead of marking with window.performance.now()

@JohnRiv JohnRiv added the bug label Sep 19, 2016
@JohnRiv JohnRiv changed the title Update getMark to return User Timing Mark if available Support multiple marks with the same key Sep 19, 2016
@JohnRiv JohnRiv added enhancement and removed bug labels Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant