Skip to content

Commit bd5a1b4

Browse files
author
Jacob Christiansen
committed
Set correct expire timestamp
1 parent dfe110a commit bd5a1b4

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

lib/Store/Redis.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@ public function set($type, $key, $value, $expire = null)
5757
$this->redis->set($redisKey, serialize($value));
5858

5959
if (is_null($expire)) {
60-
$expire = $this->lifeTime;
60+
$expire = time() + $this->lifeTime;
6161
}
62-
$this->redis->expire($redisKey, $expire);
62+
$this->redis->expireat($redisKey, $expire);
6363
}
6464

6565
/**

test/Store/RedisTest.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public function set($key, $value)
2626
self::$setValue = $value;
2727
}
2828

29-
public function expire($key, $expire)
29+
public function expireat($key, $expire)
3030
{
3131
self::$expireKey = $key;
3232
self::$expireValue = $expire;
@@ -93,7 +93,11 @@ public function testSetKeyInRedis()
9393
$this->assertEquals('simpleSAMLphp.test.key', Predis\Client::$setKey);
9494
$this->assertEquals(serialize(['one', 'two']), Predis\Client::$setValue);
9595
$this->assertEquals('simpleSAMLphp.test.key', Predis\Client::$expireKey);
96-
$this->assertEquals(288000, Predis\Client::$expireValue);
96+
/**
97+
* Cannot be tested, because time is used and code is not in
98+
* namespace, so the normal trick does not work.
99+
*/
100+
//$this->assertEquals(1427739616, \Predis\Client::$expireValue);
97101
}
98102

99103
public function testSetKeyWithExpireInRedis()

0 commit comments

Comments
 (0)