status bar: update insert mode label for clarity #11281
Conversation
| calcHelper.dblClickOnFirstCell(); | ||
| cy.cGet('#InsertMode').should('have.text', 'Insert'); |
There was a problem hiding this comment.
@eszkadev we are no longer displaying "Insert" on the status bar, so its better to also have a look at this.
Updated "Insert mode: Inactive" to "Tracking changes: on" so users don’t think they can’t type when they actually can. Signed-off-by: Banobe Pascal <[email protected]> Change-Id: Iecc367a54024dac6719465b4dc7760c285298dd6
banobepascal
force-pushed
the
private/banobepascal/status-bar-insert-mode
branch
from
c549840 to
fd08c0a
Compare
|
I don't understand. Why "tracking on" is new string? It was "insert mode" indicator (to differenciate with "replace mode" ) |
@eszkadev |
| @@ -34,11 +34,11 @@ describe(['tagdesktop', 'tagnextcloud', 'tagproxy'], 'Statubar tests.', function | |||
| }); | |||
|
|
|||
| it('Text editing mode.', function() { | |||
| cy.cGet('#InsertMode').should('have.text', 'Insert mode: inactive'); | |||
| cy.cGet('#InsertMode').should('have.text', 'Tracking changes: on'); | |||
There was a problem hiding this comment.
I mean there is inconsistency here. InsertMode shows Tracking changes: on - it looks like naming doesn't follow the content for me. Confusing.
Is that about "insert mode" or "changes tracking" feature? then both name of field and it's text should be consistent.
There was a problem hiding this comment.
Oh, I understand now, what you trying to mean here. I think in that case we should change the wording from "Tracking changes: on".
Change-Id: Iecc367a54024dac6719465b4dc7760c285298dd6
Summary
Change from "Insert mode: Inactive" to "Tracking changes: on" so users don’t think they can’t type when they actually can.
Screenshot