Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Per-User Change Tracking #11226

Open
vmiklos opened this issue Feb 25, 2025 · 7 comments
Open

Implement Per-User Change Tracking #11226

vmiklos opened this issue Feb 25, 2025 · 7 comments
Assignees
Labels
24.04 enhancement New feature or request

Comments

@vmiklos
Copy link
Contributor

vmiklos commented Feb 25, 2025

Is your feature request related to a problem?

Yes. When Alice keeps typing and Bob enables change tracking, then surprisingly the typed characters of Alice will form a tracked insertion, which is surprising, since that was not the case a second ago and Alice didn't do anything other than typing.

Describe the solution you'd like

Move the "is recording" setting of change tracking to the view from the model, so it's per-user. And even better if the UI has a dropdown to choose if the change tracking would be off/just me/everyone.

Additional context

This is for COOL, but seeing e.g. "show non-printable characters" is also per-view in libreoffice desktop, probably it change tracking recording should be also per-view by default on the desktop, too.

@vmiklos
Copy link
Contributor Author

vmiklos commented Feb 25, 2025

https://gerrit.libreoffice.org/c/core/+/182076 and https://gerrit.libreoffice.org/c/core/+/182142 extend the sw xml debug dump code to make this easier to understand -- what is the internal state of the doc model and the view.

@vmiklos
Copy link
Contributor Author

vmiklos commented Feb 26, 2025

https://gerrit.libreoffice.org/c/core/+/182201 adds a per-view flag to track if changes are recorded or not.

@vmiklos
Copy link
Contributor Author

vmiklos commented Feb 27, 2025

https://gerrit.libreoffice.org/c/core/+/182302 adds an in-model setter for the new flag, the getter still needs doing.

@vmiklos
Copy link
Contributor Author

vmiklos commented Feb 28, 2025

https://gerrit.libreoffice.org/c/core/+/182345 with this, you can actually have per-view track change recording: toolbar button state, insert recording, delete recording etc is now per-view, not per-document.

@vmiklos
Copy link
Contributor Author

vmiklos commented Mar 3, 2025

https://gerrit.libreoffice.org/c/core/+/182418 is towards adding UI to have both per-view and per-doc recording.

@vmiklos
Copy link
Contributor Author

vmiklos commented Mar 4, 2025

https://gerrit.libreoffice.org/c/core/+/182455 adds UI to have both per-view & per-doc recording.

@vmiklos
Copy link
Contributor Author

vmiklos commented Mar 5, 2025

https://gerrit.libreoffice.org/c/core/+/182517 adds state support for this new UI, so you can see if recording is off/just-you/everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
24.04 enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant