Calc toolbar/statusbar: fix scroll button issues on horizontal scroll #10944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bayramcicek
force-pushed
the
private/bayram/scroll-bar-bottom
branch
from
52fe9ea to
7b05e43
Compare
eszkadev
reviewed
Jan 24, 2025
eszkadev
reviewed
Jan 24, 2025
on toolbar and statusbar. - fixed "this._RTL always returns undefined" issue. scroll buttons are now correctly visible/hidden when scrolling horizontally with right/left scroll buttons. Signed-off-by: Bayram Çiçek <[email protected]> Change-Id: Ieeb124df61ba0e2dea94ea256ec1daa2f87b220b
- on RTL docs, scroll-right button arrows of statusbar and toolbar were misaligned to the left. This is fixed with 'left: 0px' Signed-off-by: Bayram Çiçek <[email protected]> Change-Id: I5c837244352d37342864b7413f0546cae8c60a25
- Scrolling toolbar and statusbar with Shift + mouseWheelUp/Down does not hide/show the scroll right/left buttons correctly. Therefore, right/left buttons overlap with other elements. All issues are fixed. Signed-off-by: Bayram Çiçek <[email protected]> Change-Id: I60608a8a1395d87911c520d265fce0c3b25d8da4
bayramcicek
force-pushed
the
private/bayram/scroll-bar-bottom
branch
from
7b05e43 to
88e852a
Compare
eszkadev
reviewed
Jan 28, 2025
to automatically bind 'this'. Signed-off-by: Bayram Çiçek <[email protected]> Change-Id: Ie80b750ade42c72285c116c0a0b75d6f9e0fa38c
bayramcicek
force-pushed
the
private/bayram/scroll-bar-bottom
branch
from
88e852a to
4607e27
Compare
eszkadev
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed "this._RTL always returns undefined" issue. scroll buttons are now correctly visible/hidden when scrolling horizontally with right/left scroll buttons.
aligned scroll-right button arrows on RTL docs
Calc: show/hide scroll buttons correctly with shift + mouse wheel
Change-Id: Ieeb124df61ba0e2dea94ea256ec1daa2f87b220b
TODO
LTR docs:
Shift+mouseWheelUp/Downdoes not hide/show the scroll right/left buttons correctly. Therefore right/left buttons overlap with other elementsRTL docs:
this._RTLalways returnsundefined. So we couldn't know if the doc is RTL or LTR.Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay