cypress: do not use unstable id in Writer tests

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: I6d7d82b502a604c18e415ca5fb554b2684a27a20

Author: eszkadev

cypress_test/integration_tests/common/desktop_helper.js

@@ -325,8 +325,8 @@ function toggleComments(resolved = false) {
 	var mode = Cypress.env('USER_INTERFACE');
 	if (mode === 'notebookbar') {
 		cy.cGet('#Review-tab-label').click();
-		if (resolved) cy.cGet('#review-show-resolved-annotations').click();
-		else cy.cGet('#showannotations').click();
+		if (resolved) getNbIcon('ShowResolvedAnnotations', 'Review').click();
+		else cy.cGet('.showannotations').click();
 		// to avoid notebookbar collapse in subsequent calls to toggleComments.
 		cy.cGet('#Home-tab-label').click();
 	} else {

cypress_test/integration_tests/desktop/writer/image_operation_spec.js

@@ -26,8 +26,7 @@ describe(['tagdesktop'], 'Image Operation Tests', function() {
 		insertImage();
 		helper.assertImageSize(248, 63);
 		cy.cGet('#test-div-shape-handle-3').should('exist');
-		cy.cGet('#Crop').should('be.visible');
-		cy.cGet('#Crop').click();
+		desktopHelper.getNbIcon('Crop', 'Picture').click();
 
 		cy.cGet('#test-div-shape-handle-3').then(($handle) => {
 			const rect = $handle[0].getBoundingClientRect();

cypress_test/integration_tests/desktop/writer/jsdialog_widgets_spec.js

@@ -1,12 +1,13 @@
 /* global describe it cy require beforeEach */
 
 var helper = require('../../common/helper');
+var desktopHelper = require('../../common/desktop_helper');
 
 describe(['tagdesktop', 'tagnextcloud', 'tagproxy'], 'JSDialog widgets visual tests', function() {
 	beforeEach(function() {
 		helper.setupAndLoadDocument('writer/help_dialog.odt');
 		cy.cGet('#Help-tab-label').click();
-		cy.cGet('#about-button').click();
+		desktopHelper.getNbIcon('About', 'Help').click();
 
 		cy.cGet('#modal-dialog-about-dialog-box')
 			.should('be.visible')

cypress_test/integration_tests/desktop/writer/manage_changes_dialog_spec.js

@@ -1,6 +1,7 @@
 /* global describe it cy beforeEach require  */
 
 var helper = require('../../common/helper');
+var desktopHelper = require('../../common/desktop_helper');
 
 describe(['tagdesktop', 'tagnextcloud', 'tagscreenshot'], 'Manage Changes Dialog', function () {
 
@@ -10,8 +11,8 @@ describe(['tagdesktop', 'tagnextcloud', 'tagscreenshot'], 'Manage Changes Dialog
 
 	it('Manage changes dialog visual test', function () {
 		cy.cGet('.notebookbar #Review-tab-label').click();
-		cy.cGet('.notebookbar #overflow-button-review-tracking').click();
-		cy.cGet('.notebookbar #review-accept-tracked-changes').click();
+		desktopHelper.getNbIconArrow('TrackChanges', 'Review').click();
+		desktopHelper.getNbIcon('AcceptTrackedChanges', 'Review').click();
 		cy.cGet('#AcceptRejectChangesDialog').should('be.visible');
 		cy.cGet('#writerchanges .ui-treeview-entry.ui-treeview-expandable[aria-level="1"] .ui-treeview-expander-column').click();
 		cy.wait(100);

cypress_test/integration_tests/desktop/writer/notebookbar_spec.js

@@ -21,7 +21,7 @@ describe(['tagdesktop'], 'Notebookbar tests.', function() {
 	it('Apply bold font from dropdown in Format tab', function() {
 		helper.setDummyClipboardForCopy();
 		cy.cGet('.notebookbar #Format-tab-label').click();
-		cy.cGet('.notebookbar .unoFormatMenu .unoarrow').click();
+		desktopHelper.getNbArrow('FormatMenu', 'Format').click();
 		cy.cGet('#format-FormatMenu-dropdown').should('exist');
 		cy.cGet('#format-FormatMenu-dropdown #format-FormatMenu-entry-0').click(); // Bold
 		cy.cGet('#format-FormatMenu-dropdown').should('not.exist');

cypress_test/integration_tests/desktop/writer/replace_dialog_spec.js

@@ -1,6 +1,7 @@
 /* global describe it cy beforeEach require */
 
 var helper = require('../../common/helper');
+var desktopHelper = require('../../common/desktop_helper');
 
 describe(['tagdesktop', 'tagnextcloud', 'tagproxy'], 'Replace Dialog Tests', function() {
     beforeEach(function() {
@@ -22,7 +23,7 @@ describe(['tagdesktop', 'tagnextcloud', 'tagproxy'], 'Replace Dialog Tests', fun
     it('Replace button should open search dialog with replace tab active', function() {
         cy.viewport(1920,1080);
         // Click the Replace button from the notebookbar
-        cy.cGet('#home-search-dialog-button').click();
+        desktopHelper.getNbIcon('SearchDialog', 'Home').click();
         cy.cGet('#FindReplaceDialog').should('be.visible');
 
         // Verify that the replace tab is active
@@ -116,4 +117,4 @@ describe(['tagdesktop', 'tagnextcloud', 'tagproxy'], 'Replace Dialog Tests', fun
         // Verify it's unchecked
         cy.cGet('#matchcase-input').should('not.be.checked');
     });
-});
+});

cypress_test/integration_tests/desktop/writer/sign_spec.js

@@ -12,7 +12,7 @@ describe(['tagdesktop', 'tagnextcloud', 'tagproxy'], 'Sign operations.', functio
 
 		// When signing that document:
 		cy.cGet('#File-tab-label').click();
-		cy.cGet('#signature-button').click();
+		desktopHelper.getNbIcon('Signature').click();
 		// Without the accompanying fix in place, this test would have failed with:
 		// This element `<button#sign.ui-pushbutton.jsdialog.hidden>` is not visible because it has CSS property: `display: none`
 		cy.cGet('#DigitalSignaturesDialog #sign.ui-pushbutton-wrapper button').click();

cypress_test/integration_tests/desktop/writer/stylebar_spec.js

@@ -1,6 +1,7 @@
 /* global describe it cy beforeEach require */
 
 var helper = require('../../common/helper');
+var desktopHelper = require('../../common/desktop_helper');
 
 describe(['tagdesktop'], 'Test style sidebar', function() {
 
@@ -9,7 +10,7 @@ describe(['tagdesktop'], 'Test style sidebar', function() {
 		cy.viewport(1920,1080);
 
 		cy.cGet('#Format-tab-label').click();
-		cy.cGet('#format-style-dialog').click();
+		desktopHelper.getNbIcon('StyleDialog', 'Format').click();
 	});
 
 	it('Style sidebar context menu on node with spaces', function() {