cid#512050 Variable copied when it could be moved

caolanm · vmiklos · commit c5af5fa44cd3 · 2025-03-31T11:03:46.000+02:00
Signed-off-by: Caolán McNamara &lt;caolan.mcnamara@collabora.com&gt;
Change-Id: I765d4a9d1bbc6642b029adfd1feaeba2cf826626
diff --git a/kit/ForKit.cpp b/kit/ForKit.cpp
@@ -548,7 +548,7 @@ static int createLibreOfficeKit(const std::string& childRoot,
                        DisplayVersion, sysTemplateIncomplete, spareKitId);
         };
 
-        auto parentFunc = [childRoot, jailId](int pid)
+        auto parentFunc = [childRoot, jailId = std::move(jailId)](int pid)
         {
             // Parent
             if (pid < 0)

Original file line number	Diff line number	Diff line change
`@@ -548,7 +548,7 @@ static int createLibreOfficeKit(const std::string& childRoot,`
`548`	`548`	`DisplayVersion, sysTemplateIncomplete, spareKitId);`
`549`	`549`	`};`
`550`	`550`
`551`		`- auto parentFunc = [childRoot, jailId](int pid)`
	`551`	`+ auto parentFunc = [childRoot, jailId = std::move(jailId)](int pid)`
`552`	`552`	`{`
`553`	`553`	`// Parent`
`554`	`554`	`if (pid < 0)`