Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish #1

Open
16 of 25 tasks
ColinEberhardt opened this issue Sep 13, 2018 · 2 comments
Open
16 of 25 tasks

Polish #1

ColinEberhardt opened this issue Sep 13, 2018 · 2 comments

Comments

@ColinEberhardt
Copy link
Owner

ColinEberhardt commented Sep 13, 2018

https://blog.scottlogic.com/ceberhardt/assets/yahoo-finance.png versus https://bl.ocks.org/ColinEberhardt/b7dbd9fabb414f7f156507840e69b4d6/826f8ed77d739058e0430b855cc722b1fafaa5a5

  • Font family (looks to be using a very light font, Helvetica Neue or Nimbus Sans)
  • Legend styling (grey labels, black text, title case, transparent?)
  • Legend content (time not shown, vol & change shown)
  • Pixel snapping (doesn't look universally crisp or soft)
  • Series labels
  • Axis style (black versus grey)
  • X Axis label styling (bold)
  • X Axis tick style (length)
  • X Axis tick position (first of day)
  • Y Scale padding (theirs seems to be symmetrical but ours seems offset)
  • Y Axis width (too small)
  • Y Axis label (remove right offset, reduce bottom offset)
  • Y Axis vertical bars (edge of plot area (possibly consequence of data), edge of chart)
  • Y Axis annotation label (not veritically centered)
  • Y Axis annotation position (no margin to plot area)
  • Chart top border
  • EMA series (not shown for close periods)
  • Vertical band line style (dotted)
  • Vertical band axis tick (triangle)
  • Vertical band background (can't tell but ours seems to be slightly darker)
  • Vertical band sigels ("funky icons")
  • Crosshair (not sure on yahoo styling but we should probably not use our out the box styling)
  • Watermark (figured we could have some fun with the words)
  • Blue lines at top (not sure what these are)
  • Volume bar styling (colour more faded)
@ColinEberhardt
Copy link
Owner Author

Blue lines at top (not sure what these are)

I think these are underlined menu options from UI that has been cropped from the image

@ColinEberhardt
Copy link
Owner Author

ColinEberhardt commented Sep 13, 2018

EMA series (not shown for close periods)

=> d3fc/d3fc#1194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant