-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Four pylint errors in utils and another test failure #301
Comments
Hey, @juliangilbey we need to update this function for creating custom palettes, it is totally out of date after the last big update we have. I'll be working on it, for now, I've just raised a NonImplementedError. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was looking at issue #298 and have submitted a patch for it. Unfortunately, though, the test still fails, because
qdarkstyle.utils.images.create_images()
requires the palette passed to it to have anID
component, but when the new palette is created byqdarkstyle.utils.scss.create_custom_qss()
, it is not given anID
before callingcreate_images()
. I am not sure what theID
should be, so I'm a little wary of trying to patch it myself.I did follow the code a little further and stumbled on another issue. So I then decided to run pylint over the whole package, and found four errors in the
utils
section, so at least they're localised. (All of the other errors reported were false positives due to pylint not being able to identify the contents ofpyqt
.)This is a call to the
run_process
function from theQSSFileHandler
class. I have no idea what the palette should be, so I don't know how to fix this issue.This is a call to
create_qss()
which only takes apalette
argument, and then defines its own filepaths. Perhaps the intention is that these parameters should override the defaults defined in the current body of the function?The text was updated successfully, but these errors were encountered: