Skip to content

Commit c934523

Browse files
committed
Refactor is_bot_user function to improve actor type handling and logging
1 parent e0c1540 commit c934523

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

pr_agent/servers/bitbucket_app.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,11 +98,14 @@ async def _perform_commands_bitbucket(commands_conf: str, agent: PRAgent, api_ur
9898

9999
def is_bot_user(data) -> bool:
100100
try:
101-
if data["data"]["actor"]["type"] != "user":
102-
get_logger().info(f"BitBucket actor type is not 'user': {data['data']['actor']['type']}")
101+
actor = data.get("data", {}).get("actor", {})
102+
# allow actor type: user . if it's "AppUser" or "team" then it is a bot user
103+
allowed_actor_types = {"user"}
104+
if actor and actor["type"].lower() not in allowed_actor_types:
105+
get_logger().info(f"BitBucket actor type is not 'user', skipping: {actor}")
103106
return True
104107
except Exception as e:
105-
get_logger().error("Failed 'is_bot_user' logic: {e}")
108+
get_logger().error(f"Failed 'is_bot_user' logic: {e}")
106109
return False
107110

108111

0 commit comments

Comments
 (0)