-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large spaces between paragraphs #3865
Comments
@Codeinwp/design-team what do you think about this? |
@cristian-ungureanu What defines the spacing between paragraphs? Is there a Block Gap value in GB editor or it is just bottom margin of a paragraph? I don't personally find it a huge issue, but I could live with a value of 24px instead of 30px if you guys think it's better. I also think that is has to do with the specific visual context. In the example screenshot above, we have multiple paragraphs with identical length and text. This affects the overall perception of the spacing. I think in real-life circumstances the spacing looks ok (screenshots from other demos below). For the specific user perhaps he can add a line of custom CSS to decrease the bottom margin of the paragraphs, instead for us to change the value for everyone. Let me know your thoughts. |
@JohnPixle is just the bottom margin of a paragraph. I think 24px would be better, but I agree with you. It might depend on the context. It might be useful to add a customization control for that. Not sure where and how. Maybe we can group it with the page top / bottom margin or add it in Otter somehow 🤔 |
TLDR:Good idea, but we should first investigate if this won't add too much complexity and weight on us, especially when thinking about how it would work long term in the context of Neve + other products Explainer thoughts:
Screen.Recording.2023-03-16.at.13.09.42.mov
|
Thanks for the input @mghenciu, I agree. If I remember correctly we had attempted to include such a control for block gaps in Neve, but there was also some kind of limitation with the theme.json file or something similar, I cant quite recall. My suggestion is to either use 24px for paragraph margin, or do nothing. I would definitely suggest NOT to mess with block gaps / spacing a this point. |
I think here we can go with nothing, we can have like a doc around this on how to change it manually, but for now we can keep it like this. |
Description
A user from Facebook reported that the spaces between paragraphs are too big. They are currently at 30px, which seems a little bit large. I'm opening this to start a discussion about this.
Step-by-step reproduction instructions
On a post, add multiple paragraphs. Check them on the front end.
Screenshots, screen recording, code snippet or Help Scout ticket
Environment info
No response
Is the issue you are reporting a regression
No
The text was updated successfully, but these errors were encountered: