Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large spaces between paragraphs #3865

Open
cristian-ungureanu opened this issue Mar 2, 2023 · 6 comments
Open

Large spaces between paragraphs #3865

cristian-ungureanu opened this issue Mar 2, 2023 · 6 comments
Labels
customer report Indicates the request came from a customer. question Can be used to identify issues that are asking a question about the code or how to use the project.

Comments

@cristian-ungureanu
Copy link
Contributor

Description

A user from Facebook reported that the spaces between paragraphs are too big. They are currently at 30px, which seems a little bit large. I'm opening this to start a discussion about this.

Step-by-step reproduction instructions

On a post, add multiple paragraphs. Check them on the front end.

Screenshots, screen recording, code snippet or Help Scout ticket

Screenshot 2023-03-02 at 09 48 38

Environment info

No response

Is the issue you are reporting a regression

No

@cristian-ungureanu cristian-ungureanu added question Can be used to identify issues that are asking a question about the code or how to use the project. customer report Indicates the request came from a customer. labels Mar 2, 2023
@selul
Copy link
Contributor

selul commented Mar 14, 2023

@Codeinwp/design-team what do you think about this?

@JohnPixle
Copy link

@cristian-ungureanu What defines the spacing between paragraphs?

Is there a Block Gap value in GB editor or it is just bottom margin of a paragraph?

I don't personally find it a huge issue, but I could live with a value of 24px instead of 30px if you guys think it's better.

I also think that is has to do with the specific visual context. In the example screenshot above, we have multiple paragraphs with identical length and text. This affects the overall perception of the spacing.

I think in real-life circumstances the spacing looks ok (screenshots from other demos below).

Screenshot 2023-03-15 at 2 00 35 PM

Screenshot 2023-03-15 at 2 06 15 PM

For the specific user perhaps he can add a line of custom CSS to decrease the bottom margin of the paragraphs, instead for us to change the value for everyone.

Let me know your thoughts.

@cristian-ungureanu
Copy link
Contributor Author

@JohnPixle is just the bottom margin of a paragraph. I think 24px would be better, but I agree with you. It might depend on the context.

It might be useful to add a customization control for that. Not sure where and how. Maybe we can group it with the page top / bottom margin or add it in Otter somehow 🤔

@mghenciu
Copy link

TLDR:

Good idea, but we should first investigate if this won't add too much complexity and weight on us, especially when thinking about how it would work long term in the context of Neve + other products


Explainer thoughts:

  • Blocks spacing is already an option for Style settings in the Core FSE Themes (attached below); so it may be a good idea overall.
  • and looks like a challenge that more users have, because there's even a guide for this
Screen.Recording.2023-03-16.at.13.09.42.mov

  • but none of the popular themes, like Astra, Kadence, Blocksy have this option. This is either good or bad, meaning that there can be potential to add it or the feature is too complex and that's why nobody added it so far.
  • and this may need to some research in terms of how it would work with 3rd party products like blocks plugins and so on. For example even if we add this option in Neve, there can be overrides that should work as expected for example there one from Elementor

Screenshot 2023-03-16 at 13 18 37

@JohnPixle
Copy link

Thanks for the input @mghenciu, I agree.

If I remember correctly we had attempted to include such a control for block gaps in Neve, but there was also some kind of limitation with the theme.json file or something similar, I cant quite recall.

My suggestion is to either use 24px for paragraph margin, or do nothing. I would definitely suggest NOT to mess with block gaps / spacing a this point.

@selul
Copy link
Contributor

selul commented Mar 20, 2023

I think here we can go with nothing, we can have like a doc around this on how to change it manually, but for now we can keep it like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer report Indicates the request came from a customer. question Can be used to identify issues that are asking a question about the code or how to use the project.
Projects
None yet
Development

No branches or pull requests

4 participants