Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Options for text link styling #3581

Open
JohnPixle opened this issue Aug 22, 2022 · 2 comments
Open

Suggestion: Options for text link styling #3581

JohnPixle opened this issue Aug 22, 2022 · 2 comments
Labels
enhancement Request to improve or optimize an existing feature or functionality in the project

Comments

@JohnPixle
Copy link

There have been some earlier discussions about including options for link styles in Neve, so here is a suggestion that we can evaluate and approach at some point.

Context:

Currently all links are by default underlined, and are assigned the primary accent color on normal state, and the secondary accent on hover. Turns out we need a more flexible mechanism to assign colors, and on top of that, perhaps provide some more flexibility on the overall style.

👉🏻 Figma board.

Suggestion

I believe we can include the Link settings in the same panel where we have the buttons controls, and rename the panel into "Buttons and links". Please refer to the attached image.

We can start with providing the following style options:

  • Plain
    Links appear as Plain text (not underlined) with color controls for normal and hover states.

  • Underlined
    Links appear underlined in normal state. Underline is removed on hover.

  • Highlight
    A third option (not critically necessary) where links appear highlighted. User has related color controls for both normal and hover.

Link styles


Please let me know your thoughts on this, perhaps we can start with a very simple setup with just two options (plain / underline) and their related state color controls. I would consider this low priority to be honest, but I decided to post it now in case any further discussion is needed.

@cristian-ungureanu cristian-ungureanu added the enhancement Request to improve or optimize an existing feature or functionality in the project label Aug 22, 2022
@cristian-ungureanu
Copy link
Contributor

Thank you @JohnPixle, this sounds great! I think the task is pretty clear and we can tackle it after Neve 3.4.

@JohnPixle
Copy link
Author

Awesome, thanks 🚀
Let me know if you'll need anything at any point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request to improve or optimize an existing feature or functionality in the project
Projects
None yet
Development

No branches or pull requests

2 participants