-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for 'cleanup' configuration option #25
Comments
Actually |
Documentation:
I had another look today. I see that The actual logic is: public function _beforeSuite()
{
if ($populate) {
if ($cleanup) {
dropAllTables();
}
loadDump();
}
}
public function _before()
{
if ($cleanup && $populate) {
dropAllTables();
loadDump();
}
} Also they have additional conditions and only run if either dump file is non-empty or populator setting is set.
|
Thank you for having a look and specifying what actually happens. Maybe the docs for cleanup could be like: cleanup: false - whether the dump should be reloaded before each test, this includes the dropping of all tables |
Hi,
seems like the documentation for the 'cleanup' configuration option ist not correct:
cleanup: false - whether the dump should be reloaded before each test
It think more correct would be:
cleanup: false - whether all database tables should be dropped
I am not quite sure if this dropping happens once or before each test.
The docs mention the 'clearing' of the database, but not in connection with this option.
Make this more precise would be great!
The text was updated successfully, but these errors were encountered: