Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for 5.6? #133

Open
rbruhn opened this issue Feb 26, 2018 · 18 comments
Open

Update for 5.6? #133

rbruhn opened this issue Feb 26, 2018 · 18 comments

Comments

@rbruhn
Copy link

rbruhn commented Feb 26, 2018

Any plans to updated this for 5.6? The issue when updating seems to go back to CodeSleeve/stapler and not being able to install symfony/http-foundation 4

@diggersworld
Copy link

Same issue here Laravel 5.6 now uses Symfony 4.

codesleeve/stapler v1.2.0 requires symfony/http-foundation ~2.3|~3.0

@austenc
Copy link

austenc commented Mar 8, 2018

I'm also running into this problem when trying to upgrade a Laravel app to 5.6. @rbruhn @diggersworld did you guys find an interim solution to this?

@rbruhn
Copy link
Author

rbruhn commented Mar 8, 2018

No, I've not been able to update yet. Been busy with other things so haven't gotten back to it yet.

@diggersworld
Copy link

I've been keeping an eye on the codesleeve/stapler package to see if there has been any movement towards Symfony 4 compatibility. Sadly nothing yet, so my upgrade to the 5.6 is currently sat in a pull request.

@austenc
Copy link

austenc commented Mar 8, 2018

Thanks for responding guys... yeah... it's a bummer that this is the package that seems to hold up every Laravel upgrade, but there hasn't been any commit activity since October. Seems there are some stapler issues with php 7.2 also.

@rbruhn
Copy link
Author

rbruhn commented Mar 8, 2018

Well, definitely need this package. I don't know of one that can replace it easily. When I finish some current work I'm doing, I will perhaps create a fork and see what I can tweak.

@rbruhn
Copy link
Author

rbruhn commented Mar 8, 2018

I created a pull request for this issue.
In the meantime, you can use the changes on my fork by using the following in your composer file. I had to delete my vendor and lock file, then reinstalled. Might have just been me though.

"require": {
        "codesleeve/laravel-stapler": "1.0.*",
        "codesleeve/stapler": "dev-master as 1.2.0",
},
"repositories": [
        {
            "type": "git",
            "url": "https://github.com/rbruhn/stapler.git"
        }
],

@austenc
Copy link

austenc commented Mar 8, 2018

@rbruhn Check out https://github.com/czim/laravel-paperclip I think it could be what we're all looking for in a more modern version of stapler

@franzdumfart
Copy link

@rbruhn Works perfect, thanks! Hoping for an official release soon 🤞

@skarampatakis
Copy link

@rbruhn I have followed your instructions and laravel-stapler get's installed correctly.

But the resource->path() always returns missing file.

/public/resources/original/missing.png

This was working before changes. Is there something I am missing? Thank you in advance.

@rbruhn
Copy link
Author

rbruhn commented Mar 30, 2018

I would check your paths then. The only thing I changed was the composer.json file so it included 3.0

"symfony/http-foundation": "~2.3|~3.0",

I just uploaded some banners and logos to my test server and it's working fine.

@rbruhn
Copy link
Author

rbruhn commented Mar 30, 2018

@austenc will check it out. It seems like this repo isn't going to be supported. Thanks.

@skarampatakis
Copy link

I am on PHP 7.2 if this makes any sense.

@rbruhn
Copy link
Author

rbruhn commented Mar 30, 2018

Don't know then. I'm on 7.1

@skarampatakis
Copy link

OK. Thank you for your support. I made some debugging and it seems that the problem was with the upgrade of Laravel itself. I was upgrading from 5.2 to 5.6.

The problem was that the model binding was not working. I fixed the code on Kernel and now everything works as supposed to.

Thank you a lot!

@alankarglobant
Copy link

alankarglobant commented Jul 4, 2018

@skarampatakis: Could you please post your changes here because I am planning to migrate my application from laravel 5.1 to 5.6 and want to use this library. Could you please share your changes related to composer file or an example of what changes you have made in the Kernel. It would be a great help from your side if you share the changes.

Thank you,
Alankar More

@austenc
Copy link

austenc commented Jul 4, 2018

@alankarglobant I highly recommend utilizing https://github.com/czim/laravel-paperclip instead. This repo is dead.

@skarampatakis
Copy link

@alankarglobant you could check the changes I made on Kernel.php here okgreece/Alignment@58a1342.

I hope it will work for you also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants