Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Dashing into obstacle may get you stuck #57

Open
Venefilyn opened this issue Apr 27, 2020 · 2 comments
Open

[Bug] Dashing into obstacle may get you stuck #57

Venefilyn opened this issue Apr 27, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@Venefilyn
Copy link

Describe the bug
Sometimes when dashing into an obstacle your character will simply stop, not die, and you can't move anything

To Reproduce
Not reproducible 100% of the time.

Steps to reproduce the behavior:

  1. Start game
  2. Dash into obstacle
  3. Maybe get stuck and unable to do anything

Expected behavior
You die

Screenshots
If applicable, add screenshots to help explain your problem.
https://cloud.spytec.se/s/wC3LQxEjJTa77HX

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Firefox
  • Version: 76.0b8
@Venefilyn Venefilyn added the bug Something isn't working label Apr 27, 2020
@Venefilyn Venefilyn changed the title [Bug] Dashing into obstacble may get you stuck [Bug] Dashing into obstacle may get you stuck Apr 27, 2020
@RoddieKieley
Copy link
Member

Attempted to reproduce, reproduced, and found that the Dash state upon entering does:

this.playerCollisionShape.Disabled = true; this.slideCollisionShape.Disabled = false;

if the player is on the floor. However on Dash Exit it does not revert those values. Commit 9d4cb6953056f75a72cb4060fd3c35e4351cf1dc to the fix-collision-bug branch appears to resolve that.

The previous commit to the same branch, c94f3bfb2f26a8481c0498bbd242d6da017b2027 appears to resolve a related issue related to not dying on the Block edge in particular.

Needs third party testing and review before merge @ernesgonzalez33 @rluders @dudash

@ernesgonzalez33
Copy link
Contributor

ernesgonzalez33 commented Apr 28, 2020

After debugging for a while I found that the issue was that when the end of the dash is just before the obstacle, the death animation is not playing. This code in Player waits for the "Fall" animation to finish and then ends the game.

Now it does not wait for the animation but for a timer to finish. Reproduced and now when this issue occurs it just waits for a second an a half (what the animation lasts) and it ends the game. PR #59

Won't close the issue since this problem needs further investigation to what is making the animation don't play.

Needs third party testing and review before merge @RoddieKieley @rluders @dudash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants