Fix unexpected crash from background music (#675)

Author: SadPencil

DXMainClient/DXGUI/Generic/MainMenu.cs

@@ -929,20 +929,20 @@ private void PlayMusic()
             if (!isMediaPlayerAvailable)
                 return; // SharpDX fails at music playback on Vista
 
-            if (themeSong != null && UserINISettings.Instance.PlayMainMenuMusic)
+            try
             {
-                isMusicFading = false;
-                MediaPlayer.IsRepeating = true;
-                MediaPlayer.Volume = (float)UserINISettings.Instance.ClientVolume;
-
-                try
+                if (themeSong != null && UserINISettings.Instance.PlayMainMenuMusic)
                 {
+                    isMusicFading = false;
+                    MediaPlayer.IsRepeating = true;
+                    MediaPlayer.Volume = (float)UserINISettings.Instance.ClientVolume;
+
                     MediaPlayer.Play(themeSong);
                 }
-                catch (InvalidOperationException ex)
-                {
-                    Logger.Log("Playing main menu music failed! " + ex.ToString());
-                }
+            }
+            catch (Exception ex)
+            {
+                Logger.Log("Playing main menu music failed! " + ex.ToString());
             }
         }
 
@@ -956,15 +956,22 @@ private void FadeMusic(GameTime gameTime)
             if (!isMediaPlayerAvailable || !isMusicFading || themeSong == null)
                 return;
 
-            // Fade during 1 second
-            float step = SoundPlayer.Volume * (float)gameTime.ElapsedGameTime.TotalSeconds;
+            try
+            {
+                // Fade during 1 second
+                float step = SoundPlayer.Volume * (float)gameTime.ElapsedGameTime.TotalSeconds;
 
-            if (MediaPlayer.Volume > step)
-                MediaPlayer.Volume -= step;
-            else
+                if (MediaPlayer.Volume > step)
+                    MediaPlayer.Volume -= step;
+                else
+                {
+                    MediaPlayer.Stop();
+                    isMusicFading = false;
+                }
+            }
+            catch (Exception ex)
             {
-                MediaPlayer.Stop();
-                isMusicFading = false;
+                Logger.Log("Fading music failed! Message: " + ex.ToString());
             }
         }
 
@@ -979,17 +986,24 @@ private void FadeMusicExit()
                 return;
             }
 
-            float step = MEDIA_PLAYER_VOLUME_EXIT_FADE_STEP * (float)UserINISettings.Instance.ClientVolume;
-
-            if (MediaPlayer.Volume > step)
+            try
             {
-                MediaPlayer.Volume -= step;
-                AddCallback(new Action(FadeMusicExit), null);
+                float step = MEDIA_PLAYER_VOLUME_EXIT_FADE_STEP * (float)UserINISettings.Instance.ClientVolume;
+
+                if (MediaPlayer.Volume > step)
+                {
+                    MediaPlayer.Volume -= step;
+                    AddCallback(new Action(FadeMusicExit), null);
+                }
+                else
+                {
+                    MediaPlayer.Stop();
+                    ExitClient();
+                }
             }
-            else
+            catch (Exception ex)
             {
-                MediaPlayer.Stop();
-                ExitClient();
+                Logger.Log("Fading music on exit failed! Message: " + ex.ToString());
             }
         }