Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the "connection impersonation" Metabase feature #219

Closed
phil-schreiber opened this issue Jan 18, 2024 · 6 comments · Fixed by #240
Closed

Add support for the "connection impersonation" Metabase feature #219

phil-schreiber opened this issue Jan 18, 2024 · 6 comments · Fixed by #240
Assignees
Labels
blocked-by-jdbc enhancement New feature or request

Comments

@phil-schreiber
Copy link

Hey,
we're running an instance of metabase pro version
v1.47.8

We using clickhouse driver version:
1.2.4

On clickhouse databases the data access option Impersonated does not show up. On postgres sources the option does show up.

Any idea why we might not see the option for clickhouse?
It's a crucial feature for us and the main reason we bought into metabase pro.

@phil-schreiber phil-schreiber added the question Further information is requested label Jan 18, 2024
@slvrtrn
Copy link
Collaborator

slvrtrn commented Jan 18, 2024

Unfortunately, I had to roll back the support of it because of #192

@phil-schreiber
Copy link
Author

phil-schreiber commented Jan 18, 2024

Unfortunately, I had to roll back the support of it because of #192

@slvrtrn Is it planned to fix it? Any ETA? Thanks in advance

@slvrtrn
Copy link
Collaborator

slvrtrn commented Feb 14, 2024

Apologies for the late reply. We are currently discussing whether it will be possible to memorize the session settings within the underlying JDBC driver, so it will not trigger the issues with the clustered on-premise deployments.
Please stay tuned.

@slvrtrn
Copy link
Collaborator

slvrtrn commented Feb 18, 2024

@phil-schreiber, if everything goes well with the Java driver experiment, the ETA might be ClickHouse 24.3, best case scenario 24.2 - we will still need to make a minor adjustment to how the HTTP interface works.

@slvrtrn
Copy link
Collaborator

slvrtrn commented Apr 17, 2024

@phil-schreiber, sincere apologies for the delay. Here's an update.

  • We have merged a new ClickHouse HTTP interface feature that allows to properly set a role for a particular statement, and that was the main blocker: Add role query parameter to the HTTP interface ClickHouse#62669
  • Here's the PR for the JDBC driver feature (Feature: Persist effect of "SET ROLE" queries.  clickhouse-java#1569), which relies on the changeset above
  • I am going to finalize my testing with clusters with the updated JDBC driver and the latest ClickHouse build. There is a significant chance that everything will finally work with the impersonation feature and roles setting on the cluster setups.
  • If all is good, this feature will work with ClickHouse 24.4+.

@slvrtrn slvrtrn changed the title How to get connection impersonation working? Add support for the "connection impersonation" Metabase feature Apr 17, 2024
@slvrtrn slvrtrn added enhancement New feature or request and removed question Further information is requested blocked-by-jdbc labels Apr 17, 2024
@slvrtrn slvrtrn self-assigned this Apr 17, 2024
@slvrtrn slvrtrn mentioned this issue May 27, 2024
2 tasks
@slvrtrn
Copy link
Collaborator

slvrtrn commented May 28, 2024

Added in 1.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-by-jdbc enhancement New feature or request
Projects
None yet
2 participants