Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve database types mapping #182

Open
slvrtrn opened this issue Aug 1, 2023 · 0 comments
Open

Improve database types mapping #182

slvrtrn opened this issue Aug 1, 2023 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@slvrtrn
Copy link
Collaborator

slvrtrn commented Aug 1, 2023 •
edited

  • DateTime/DateTime64 should likely be mapped to DateTimeWithTZ
    • Changing the type triggers a lot of failing tests from the Metabase bundle
    • Even more tests are failing if related features such as :convert-timezone and :set-timezone are enabled.
  • Revisit large (unsigned) integers (128+ bits) mapping which is currently type/*

I'd like to hear from the community if this will be useful in specific use cases (with examples, if possible) or if there are other types that are not supported by the driver properly as of 1.2.0+.
Please don't hesitate to leave a comment here.
@slvrtrn slvrtrn added the enhancement New feature or request label Aug 1, 2023
@slvrtrn slvrtrn pinned this issue Aug 1, 2023
@slvrtrn slvrtrn unpinned this issue Aug 1, 2023
@slvrtrn slvrtrn pinned this issue Aug 1, 2023
@slvrtrn slvrtrn added the help wanted Extra attention is needed label Aug 1, 2023
@brendavarguez brendavarguez mentioned this issue Aug 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@slvrtrn