You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Can we think of a better name? For example BackgroundFieldInfo is one. That's sorta clumsy though. Maybe we can come up with something more concise and elegant.
It's not a
Field
. The docstring for the struct admits as much:Oceananigans.jl/src/Fields/background_fields.jl
Lines 33 to 41 in 7a4b3f0
and this temporary struct is always thrown away to build a "real" field:
Oceananigans.jl/src/Fields/background_fields.jl
Lines 63 to 64 in 7a4b3f0
The problem is that the name leads to confusing patterns like
Oceananigans.jl/examples/tilted_bottom_boundary_layer.jl
Line 98 in 7a4b3f0
where
B_field
is not a field. Indeed, later on when we need a "real" field we have to writeOceananigans.jl/examples/tilted_bottom_boundary_layer.jl
Line 178 in 7a4b3f0
Can we think of a better name? For example
BackgroundFieldInfo
is one. That's sorta clumsy though. Maybe we can come up with something more concise and elegant.cc @tomchor @hdrake @liuchihl because you are using this feature
The text was updated successfully, but these errors were encountered: