Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MC-2263] Use weak reference check in controller hide #379

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

nzagorchev
Copy link
Contributor

Overview

  • Use weak reference check in in-apps controller hideFromWindow: which dismisses the in-apps
  • Mitigate potential crash on [CTInAppHTMLViewController hideFromWindow:]

Implementation

  • Add a new method hideFromWindow:completion to CTInAppDisplayViewController which provides a completionBlock for hideFromWindow:
  • Add weak reference check in hideFromWindow:
  • Use the super hideFromWindow:completion in CTInAppHTMLViewController

@nzagorchev nzagorchev merged commit 5f26cf6 into develop Nov 7, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants