Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MC-1578 Fix in-apps not discarded #321

Merged
merged 1 commit into from
Apr 4, 2024
Merged

MC-1578 Fix in-apps not discarded #321

merged 1 commit into from
Apr 4, 2024

Conversation

nzagorchev
Copy link
Contributor

Background

  1. In-apps are not discarded in CS mode.
  2. In-apps are not discarded on App Launched SS mode.

Implementation

  1. Check the in-app rendering status in prepareNotificationForDisplay. If it is CleverTapInAppDiscard return and remove the in-app.
  2. Move the check for the CleverTapInAppDiscard in-app rendering status before calling evaluateOnAppLaunchedServerSide

@nzagorchev nzagorchev requested a review from akashvercetti April 3, 2024 09:25
@nzagorchev nzagorchev marked this pull request as ready for review April 3, 2024 11:58
@AishwaryaNanna AishwaryaNanna merged commit 162a5e6 into develop Apr 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akashvercetti akashvercetti akashvercetti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nzagorchev @akashvercetti @AishwaryaNanna