Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LineStrings must contain at least two points #83

Open
ian-r-rose opened this issue Oct 17, 2019 · 5 comments
Open

LineStrings must contain at least two points #83

ian-r-rose opened this issue Oct 17, 2019 · 5 comments
Assignees

Comments

@ian-r-rose
Copy link
Contributor

We are currently processing route GeoJSON into a LineString. If that GeoJSON contains a single point, we can create an invalid shape (c.f., the GeoJSON schema here, and seemingly the Geos spec somewhere).

We can catch this by filtering by ST_IsValid in our queries, but better to not have to do this.

@ian-r-rose
Copy link
Contributor Author

cc @RMK0110

@RMK0110
Copy link
Contributor

RMK0110 commented Dec 5, 2019

You're referring to the process_route function in geom_parse.sql?

@ian-r-rose
Copy link
Contributor Author

@RMK0110 Yes, that's right.

@RMK0110
Copy link
Contributor

RMK0110 commented Dec 9, 2019

@ian-r-rose Is there allowance in terms of consolidating the CREATE TABLE....trips_geos, CREATE FUNCTION...process_route and CREATE FUNCTION...geom_copy parts?

@ian-r-rose
Copy link
Contributor Author

Are you asking about restructuring some of the functions? If so, feel free to take a crack at it and bring that to code review so we can discuss.

If it's a series of bigger changes, feel free to break them into multiple PRs that each express one idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants