Generated resource and datasource for fvSiteAssociated and fvRemoteId #1233
Conversation
|
CI failing on go generate, make sure you run go generate before you push the changes. This ensures that you have not made any manual changes that the go generate command will wipe away. Please use [ignore] tag for commits that are not related text that need to be in release notes / changes. So Generated resource and datasource for fvSiteAssociated would be a minor_change. |
abrahammughal
force-pushed
the
associated_site_and_remote_id
branch
3 times, most recently
from
6ba7399 to
279aee2
Compare
abrahammughal
force-pushed
the
associated_site_and_remote_id
branch
2 times, most recently
from
d46c36f to
bed4ce3
Compare
abrahammughal
force-pushed
the
associated_site_and_remote_id
branch
from
fa001b0 to
bf67ddb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1233 +/- ##
==========================================
+ Coverage 84.05% 84.18% +0.13%
==========================================
Files 61 65 +4
Lines 17940 19076 +1136
==========================================
+ Hits 15080 16060 +980
- Misses 2054 2156 +102
- Partials 806 860 +54 ☔ View full report in Codecov by Sentry. |
|
tests are failing, please check that all test are working |
| if propertyName == "remoteCtxPcTag" || propertyName == "remotePcTag" { | ||
| validValue = "defaultValue" | ||
| } |
There was a problem hiding this comment.
I agree, we shouldn't hard code property behaviour in the generator. I suggest we provide a way to configure this in the overwrite logic instead of a constant.
gen/generator.go
Outdated
| // precedenceList := []string{classPkgName, "global"} | ||
| // for _, precedence := range precedenceList { | ||
| // if classDetails, ok := definitions.Properties[precedence]; ok { | ||
| // for key, value := range classDetails.(map[interface{}]interface{}) { | ||
| // if key.(string) == "resource_required" { | ||
| // for _, v := range value.([]interface{}) { | ||
| // if v.(string) == propertyName { | ||
| // return true | ||
| // } | ||
| // } | ||
| // } | ||
| // } | ||
| // } | ||
| // } | ||
| // return false |
There was a problem hiding this comment.
Yes please, commented out code should be removed.
docs/resources/associated_site.md
Outdated
| * `owner_key` (ownerKey) - (string) The key for enabling clients to own their data for entity correlation. | ||
| * `owner_tag` (ownerTag) - (string) A tag for enabling clients to add their own data. For example, to indicate who created this object. | ||
| * `site_id` (siteId) - (string) A number between 0 and 1000 to identify the primary site being associated. | ||
| - Default: `0.000000` |
There was a problem hiding this comment.
Should the default be a decimal value or just a whole number, eg 0?
|
|
||
| #### Required #### | ||
|
|
||
| * `key` (key) - (string) The key used to uniquely identify this configuration object. |
There was a problem hiding this comment.
this configuration object -> Associated Site object.
the description for value is not clear.
| * `key` (key) - (string) The key used to uniquely identify this configuration object. | ||
| * `value` (value) - (string) The value of the property. |
| * `key` (key) - (string) The key used to uniquely identify this configuration object. | ||
| * `value` (value) - (string) The value of the property. |
abrahammughal
force-pushed
the
associated_site_and_remote_id
branch
from
05fdd89 to
c990d3d
Compare
abrahammughal
force-pushed
the
associated_site_and_remote_id
branch
from
8c45693 to
3d94130
Compare
Fixes #1224