Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of recursive logic in the templates to incorporate grand children of the parent class as nested children within the immediate child of the parent (DCNE-145) #1186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Addition of recursive logic in the templates to incorporate grand children of the parent class as nested children within the immediate child of the parent (DCNE-145) #1186

wants to merge 1 commit into from
+44,914 −6,573

Conversation

shrsr
Copy link
Collaborator

@shrsr shrsr commented Mar 22, 2024

No description provided.

@shrsr shrsr self-assigned this Mar 22, 2024
@shrsr shrsr linked an issue Mar 22, 2024 that may be closed by this pull request
APIC Certificate Import Support - (DCNE-145) #1072
Open
samiib
samiib reviewed May 9, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you may need to rebase to get the CI working in your PR and to fix conflicts.

gen/templates/resource.go.tmpl Show resolved Hide resolved
gen/templates/resource.go.tmpl Outdated Show resolved Hide resolved
@shrsr shrsr force-pushed the nest branch 3 times, most recently from ca451a3 to 37e2f49 Compare May 22, 2024 17:12
@lhercot lhercot requested a review from samiib May 24, 2024 18:23
@samiib samiib changed the title Addition of recursive logic in the templates to incorporate grand children of the parent class as nested children within the immediate child of the parent Addition of recursive logic in the templates to incorporate grand children of the parent class as nested children within the immediate child of the parent (DCNE-145)) Aug 14, 2024
@samiib samiib changed the title Addition of recursive logic in the templates to incorporate grand children of the parent class as nested children within the immediate child of the parent (DCNE-145)) Addition of recursive logic in the templates to incorporate grand children of the parent class as nested children within the immediate child of the parent (DCNE-145) Aug 14, 2024
@shrsr shrsr force-pushed the nest branch 4 times, most recently from 8cd5007 to 74d206c Compare November 13, 2024 18:02
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.45%. Comparing base (9e2dfc6) to head (442ea53).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1186      +/-   ##
==========================================
+ Coverage   83.74%   85.45%   +1.71%     
==========================================
  Files         123      125       +2     
  Lines       56180    70689   +14509     
==========================================
+ Hits        47049    60409   +13360     
- Misses       7255     8324    +1069     
- Partials     1876     1956      +80

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shrsr shrsr force-pushed the nest branch 2 times, most recently from a7c8ca8 to d1b7238 Compare November 15, 2024 01:11
akinross
akinross requested changes Nov 18, 2024
View reviewed changes
gen/testvars/fvBD.yaml Outdated Show resolved Hide resolved
docs/resources/annotation.md Outdated Show resolved Hide resolved
docs/resources/access_interface_override.md Outdated Show resolved Hide resolved
docs/resources/application_epg.md Outdated Show resolved Hide resolved
gen/generator.go Outdated Show resolved Hide resolved
gen/generator.go Outdated Show resolved Hide resolved
gen/templates/datasource.go.tmpl Show resolved Hide resolved
gen/generator.go Show resolved Hide resolved
gen/templates/resource.go.tmpl Outdated Show resolved Hide resolved
gen/templates/resource_test.go.tmpl Outdated Show resolved Hide resolved
@shrsr shrsr force-pushed the nest branch 2 times, most recently from e7c081f to a642324 Compare November 19, 2024 01:50
@shrsr shrsr requested a review from akinross November 19, 2024 01:51
@shrsr shrsr requested a review from akinross November 19, 2024 21:26
@shrsr shrsr force-pushed the nest branch 4 times, most recently from a4da108 to 4343b42 Compare November 25, 2024 21:42
@shrsr shrsr force-pushed the nest branch 2 times, most recently from 52daaca to 0a5fdd7 Compare November 29, 2024 19:42
@shrsr shrsr requested a review from samiib December 4, 2024 15:11
@shrsr shrsr requested a review from samiib December 5, 2024 15:09
akinross
akinross requested changes Dec 6, 2024
View reviewed changes
docs/data-sources/management_access_policy.md Outdated Show resolved Hide resolved
docs/data-sources/management_access_policy.md Outdated Show resolved Hide resolved
docs/data-sources/management_access_policy.md Outdated Show resolved Hide resolved
docs/data-sources/management_access_policy.md Outdated Show resolved Hide resolved
docs/data-sources/management_access_policy.md Show resolved Hide resolved
docs/data-sources/management_access_policy.md Outdated Show resolved Hide resolved
docs/data-sources/management_access_policy.md Outdated Show resolved Hide resolved
docs/data-sources/management_access_policy.md Outdated Show resolved Hide resolved
docs/data-sources/management_access_policy.md Outdated Show resolved Hide resolved
docs/resources/application_epg.md Show resolved Hide resolved
@shrsr shrsr force-pushed the nest branch 2 times, most recently from 72d676f to fd91d10 Compare December 9, 2024 18:36
@shrsr shrsr requested a review from akinross December 9, 2024 18:36
akinross
akinross previously approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib previously approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol previously approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shrsr
[minor_change] Addition of recursive logic in the templates to incorp…
442ea53 
…orate grand children of the parent class as nested children within the immediate child of the parent
@shrsr shrsr dismissed stale reviews from gmicol, samiib, and akinross via 442ea53 December 12, 2024 14:20
sajagana
sajagana approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shrsr shrsr requested review from gmicol, akinross and samiib December 13, 2024 00:31
samiib
samiib approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samiib samiib samiib approved these changes

@sajagana sajagana sajagana approved these changes

@akinross akinross akinross approved these changes

@anvitha-jain anvitha-jain Awaiting requested review from anvitha-jain anvitha-jain is a code owner

@lhercot lhercot Awaiting requested review from lhercot lhercot is a code owner

@gmicol gmicol Awaiting requested review from gmicol gmicol is a code owner

Assignees

@shrsr shrsr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

APIC Certificate Import Support - (DCNE-145)
6 participants
@shrsr @codecov-commenter @akinross @sajagana @samiib @gmicol