Resource import support

[blimmer]

I'm excited to see that CircleCI is offering an official provider! However, we are currently blocked from using it until we can import our existing resources.

I see that import support is coming in a future release

terraform-provider-circleci/README.md

Lines 33 to 35 in 5f62daa

	## Upcoming Features in the Next Release
	- Import existing resources

However, I'm opening a dedicated issue for this so it's easier to track.

cc @david-montano-circleci - is there any ETA for this feature? We'd love to get rid of our null_resource hacks we're using today

[david-montano-circleci]

Hello. Thank you for your interest in the CircleCI Terraform provider.
We are actively working on this. There is no specific ETA, each resource has to implement its own import logic. And we are actively working on adding more resources (organizations, webhooks).
But we are pushing to support imports hopefully before October this year.

Let's keep this one and I will reference it once we start pushing import logic.

[doughlass]

Re-raising this, existing projects are able to be imported but as tf import 'module.repo_automation.circleci_project.project["my-repo"]' "github/my-org/my-repo"

But the issue comes afterwards, when you try to terraform plan your entire CircleCI Project is required to be replaced ~ organization_id = (sensitive value) # forces replacement

And then when perform ing the terraform apply you are then met with this error:

│ Could not create CircleCI project, unexpected error: 404 Not Found: {"message":"{\"message\":\"Not Found\",\"documentation_url\":\"https://docs.github.com/rest/repos/repos#get-a-repository\",\"status\":\"404\"}"}

Even though the CircleCI user actioning the apply has access to the repository.

When running with TF_LOG_PROVIDER=DEBUG, I can see that this line here looks suspect.

[DEBUG] POST https://circleci.com/api/v1.1/project/github/USERNAME/my-repo/follow it's using my USERNAME instead of the ORG NAME.

As much as I'd love to use this CircleCI terraform provider, it's unfortunately unusable.

[david-montano-circleci]

Hello @doughlass . I did add some tests for this scenario and while running them I did get the error you describe. But then tests started working so I thought this was fixed. Maybe there is something in your project configuration that makes this return the organization_id difference. I will take a look and come back with news.

[doughlass]

Hello @doughlass . I did add some tests for this scenario and while running them I did get the error you describe. But then tests started working so I thought this was fixed. Maybe there is something in your project configuration that makes this return the organization_id difference. I will take a look and come back with news.

The other issue I noticed is that organization_id would fail and would need to resort to vcs and org slug at times.

I'd been using the org id and a machine user api key to try and import, plan and apply.

[david-montano-circleci]

Hello. Imports were already implemented for most of the CircleCI Terraform resources. Some of them have to be imported with a special 'orgid/resourceid' format.
See for example this documentation.

[sauloeqt]

Hi @david-montano-circleci,

I have the same issue as @doughlass

Re-raising this, existing projects are able to be imported but as tf import 'module.repo_automation.circleci_project.project["my-repo"]' "github/my-org/my-repo"

But the issue comes afterwards, when you try to terraform plan your entire CircleCI Project is required to be replaced ~ organization_id = (sensitive value) # forces replacement

And then when perform ing the terraform apply you are then met with this error:

│ Could not create CircleCI project, unexpected error: 404 Not Found: {"message":"{\"message\":\"Not Found\",\"documentation_url\":\"https://docs.github.com/rest/repos/repos#get-a-repository\",\"status\":\"404\"}"}

Even though the CircleCI user actioning the apply has access to the repository.

When running with TF_LOG_PROVIDER=DEBUG, I can see that this line here looks suspect.

[DEBUG] POST https://circleci.com/api/v1.1/project/github/USERNAME/my-repo/follow it's using my USERNAME instead of the ORG NAME.

As much as I'd love to use this CircleCI terraform provider, it's unfortunately unusable.

I think the issue might be in the circleci-sdk-go

The second TODO, instead of org it uses user.Login which breaks the code and returns 404.

[david-montano-circleci]

Thank you @sauloeqt , I was working on other features (implementing runners) which took priority but now I will come back to this.

[sauloeqt]

Thank you @david-montano-circleci 🙏🏼