Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commit message #39

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mattrabe
Copy link
Contributor

@mattrabe mattrabe commented Oct 20, 2023

Fixes #37

@mattrabe
Copy link
Contributor Author

@KyleTryon For this one I've pulled fresh from your main branch. It fails in my CI, but maybe that means it will succeed in yours! (on my previous PR I believe I had made changes to make it pass my CI)

@rafalotufo
Copy link

Any updates on this one? I'm eager to start using this when possible. Let me know if there is anything I can do to help. Thanks!

@FellowFellow
Copy link

Ive been using fpcs/[email protected] since this PR isnt merged yet. There is only issue i found so far. The notify step isnt executed on fail -> which is bad. It seams to be fixed on this branch though since the cotify command is set to run always.

@mattrabe - really looking forward to using this update.

@mattrabe
Copy link
Contributor Author

mattrabe commented Nov 6, 2023

@FellowFellow I have published v2.1.1 of my fork, which includes all of v2.1.0, plus the changes from this PR

@KyleTryon
Copy link
Contributor

Clever! Thanks for the addition! Testing it out now, but it looks good.

@KyleTryon
Copy link
Contributor

It may be a consequence of how we are checking out the code that maybe the parent is not being found.

fatal: ambiguous argument 'd2a5ad8cb7bfe20c63799dc36aa0fcb96ef78375^..d2a5ad8cb7bfe20c63799dc36aa0fcb96ef78375': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
fatal: ambiguous argument 'd2a5ad8cb7bfe20c63799dc36aa0fcb96ef78375^..d2a5ad8cb7bfe20c63799dc36aa0fcb96ef78375': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

https://app.circleci.com/pipelines/github/CircleCI-Public/jira-orb/206/workflows/99aeffe3-38c5-4a50-8049-ea02e75ddfb7/jobs/1645

Looking a little deeper

@GabMar
Copy link

GabMar commented Mar 8, 2024

@KyleTryon any updates on this? Due to some restrictions I can't use the forked orb of @mattrabe, so it would be awesome to have this merged 😬 let me know if I can help

@KyleTryon
Copy link
Contributor

@KyleTryon any updates on this? Due to some restrictions I can't use the forked orb of @mattrabe, so it would be awesome to have this merged 😬 let me know if I can help

Sorry. I am no longer with the company. I would recommend reaching out to support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure when merging branch with many commits addressing multiple Jira tickets
5 participants