From 014287b19d477ef7229cadf29886d1c64995aa4a Mon Sep 17 00:00:00 2001 From: Eric Ribeiro Date: Fri, 23 Sep 2022 10:31:12 -0700 Subject: [PATCH] chore: update comment to reflect dev's input (#157) --- src/scripts/install-docker-credential-helper.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/scripts/install-docker-credential-helper.sh b/src/scripts/install-docker-credential-helper.sh index d9d000d..e5eeb0c 100644 --- a/src/scripts/install-docker-credential-helper.sh +++ b/src/scripts/install-docker-credential-helper.sh @@ -64,7 +64,9 @@ if [ -n "${RELEASE_TAG}" ]; then RELEASE_VERSION="${RELEASE_TAG}" fi -# Starting from v0.7.0, the release file name is changed to docker-credential--- +# Starting from v0.7.0, the release file name is changed to docker-credential--.- +# At the moment of writing, the amd64 binary does not have a variant suffix. But this might change in the future. +# https://github.com/CircleCI-Public/docker-orb/pull/156#discussion_r977920812 minor_version="$(echo "$RELEASE_VERSION" | cut -d. -f2)" download_base_url="$base_url/download/${RELEASE_VERSION}/${HELPER_FILENAME}-${RELEASE_VERSION}"