Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USA Addresses not handled correctly in non-USA installations #5986

Open
MrClever opened this issue Feb 14, 2022 · 11 comments
Open

USA Addresses not handled correctly in non-USA installations #5986

MrClever opened this issue Feb 14, 2022 · 11 comments
Assignees
Labels

Comments

@MrClever
Copy link
Collaborator

On what page in the application did you find this issue?

DirectoryReports.php

On what type of server is this running? Dedicated / Shared hosting? Linux / Windows?

Dedicated system (Debian 11)

What browser (and version) are you running?

  • Safari 15.3 (17612.4.9.1.8)
  • Firefox 96.0.3
  • Brave 1.35.100 (Chromium 98.0.4758.87)

What version of PHP is the server running?

7.4.27

What version of SQL Server are you running?

MySQL 5.7.23-23

What version of ChurchCRM are you running?

4.4.5

Description of issue and steps to recreate

When a ChurchCRM is set up to host a non-USA locale and address defaults, any people added that happen to have USA addresses are not handled correctly. Specifically, the USA state is replaced with whatever the ChurchCRM default (local) state is, and the country is omitted.

To recreate

  1. Setup ChurchCRM with non-USA locale and default country/state to be non-USA. For this example I am using:
    Locale: en_AU
    Default Country: Australia
    Default State: NSW
  2. Create a person and associated family with a valid USA address:

Screen Shot 2022-02-14 at 12 54 50 pm

3. Generate a "People Directory" (or mailing label etc) - note state is "NSW" (should be "CA") and country is missing:

Screen Shot 2022-02-14 at 12 54 56 pm

Expected result

People Directory should correctly show the USA state and list "United States" as the country.

@brianteeman
Copy link
Contributor

A better way to do this, and for it to work globally, would be to compare the country of the church with the country of the person and not to simply hard code it for the USA

@DawoudIO
Copy link
Contributor

DawoudIO commented Jun 20, 2022

we should open a ticket that removes the US check and compare the system Country.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Oct 31, 2023
@DawoudIO DawoudIO modified the milestones: 5.1.1, vNext Nov 7, 2023
Copy link
Contributor

github-actions bot commented Dec 7, 2023

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Dec 7, 2023
Copy link
Contributor

This issue was closed because it has been stalled for 15 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 23, 2023
@respencer respencer reopened this May 3, 2024
@respencer
Copy link
Contributor

respencer commented May 3, 2024

Still an issue.

The USA is hard coded in some areas, hence the strange behavior.

@respencer respencer self-assigned this May 3, 2024
@respencer respencer removed the Stale label May 3, 2024
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jun 27, 2024
@DAcodedBEAT DAcodedBEAT removed the Stale label Jun 27, 2024
@DAcodedBEAT DAcodedBEAT removed this from the v5.4.1 milestone Jun 27, 2024
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Sep 28, 2024
@DAcodedBEAT DAcodedBEAT removed the Stale label Oct 8, 2024
Copy link
Contributor

github-actions bot commented Nov 9, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Nov 9, 2024
Copy link
Contributor

This issue was closed because it has been stalled for 15 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 24, 2024
@DAcodedBEAT DAcodedBEAT reopened this Nov 25, 2024
@github-actions github-actions bot removed the Stale label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants