Fix/remove b csv admin only setting (#7926)

## Summary

Remove deprecated CSV export permission flags (`bCSVAdminOnly` and
`bExportCSV`) that provided no real security value since users could
already export data via DataTables buttons on every table.

## Why

These settings created a false sense of security:
- `bCSVAdminOnly` - Restricted CSV option in financial report forms, but
users could still export via DataTables
- `bExportCSV` - User permission that only hid some CSV buttons, while
DataTables export remained available

Both settings added UI complexity without actual data protection.
Removing them simplifies the codebase and user management.

## Changes

### System Configuration
- Removed `bCSVAdminOnly` from `SystemConfig.php`
- Removed conditional logic from all financial report forms

### User Permissions
- Removed `isCSVExport()` and `isCSVExportEnabled()` methods from
`User.php`
- Removed permission check from `CSVExport.php`
- Updated `Header.php` to always show DataTables export buttons
- Updated cart functions to always show CSV export button
- Removed `csvExport` from admin user API response
- Removed `CSVExport` from access-denied page role descriptions

### Database
- Created `src/mysql/upgrade/6.8.0.sql` to delete both settings from
existing installations

## Files Changed

| File | Change |
|------|--------|
| `src/ChurchCRM/dto/SystemConfig.php` | Remove bCSVAdminOnly config |
| `src/ChurchCRM/model/ChurchCRM/User.php` | Remove CSV export methods |
| `src/CSVExport.php` | Remove permission check |
| `src/Include/Header.php` | Always show DataTables buttons |
| `src/FinancialReports.php` | Simplify CSV option logic |
| `src/ReminderReport.php` | Remove bCSVAdminOnly check |
| `src/TaxReport.php` | Remove bCSVAdminOnly check |
| `src/Reports/*.php` (6 files) | Remove bCSVAdminOnly checks |
| `src/finance/views/reports.php` | Remove warning message |
| `src/admin/routes/api/user-admin.php` | Remove csvExport from response
|
| `src/v2/templates/cart/cartfunctions.php` | Always show CSV button |
| `src/v2/templates/common/access-denied.php` | Remove CSVExport role |
| `src/mysql/install/Install.sql` | Remove default setting |
| `src/mysql/upgrade/6.8.0.sql` | New upgrade script |

## Testing

- ✅ CSV reports test (6 passing)
- ✅ Finance reports test (10 passing)
- ✅ Cart tests (4 passing)
- ✅ Admin reports test (1 passing)
- ✅ Admin user test (3 passing)
- ✅ No PHP errors in logs

Author: DawoudIO

src/CSVExport.php

@@ -3,14 +3,7 @@
 require_once __DIR__ . '/Include/Config.php';
 require_once __DIR__ . '/Include/Functions.php';
 
-use ChurchCRM\Authentication\AuthenticationManager;
 use ChurchCRM\dto\SystemURLs;
-use ChurchCRM\Utils\RedirectUtils;
-
-// If user does not have CSV Export permission, redirect to the menu.
-if (!AuthenticationManager::getCurrentUser()->isCSVExport()) {
-    RedirectUtils::securityRedirect("CSVExport");
-}
 
 // Get Classifications for the drop-down
 $sSQL = 'SELECT * FROM list_lst WHERE lst_ID = 1 ORDER BY lst_OptionSequence';

src/ChurchCRM/dto/SystemConfig.php

@@ -101,7 +101,6 @@ private static function buildConfigs(): array
             'sDirRoleChild'                        => new ConfigItem(8, 'sDirRoleChild', 'choice', '3', gettext('These are the family role numbers designated as child'), '', json_encode(SystemConfig::getFamilyRoleChoices(), JSON_THROW_ON_ERROR)),
             'iSessionTimeout'                      => new ConfigItem(9, 'iSessionTimeout', 'number', '3600', gettext("Session timeout length in seconds\nSet to zero to disable session timeouts.")),
             'aFinanceQueries'                      => new ConfigItem(10, 'aFinanceQueries', 'text', '28,30', gettext('Queries for which user must have finance permissions to use') . ':'),
-            'bCSVAdminOnly'                        => new ConfigItem(11, 'bCSVAdminOnly', 'boolean', '1', gettext('Should only administrators have access to the CSV export system and directory report?')),
             'iMinPasswordLength'                   => new ConfigItem(13, 'iMinPasswordLength', 'number', '6', gettext('Minimum length a user may set their password to')),
             'iMinPasswordChange'                   => new ConfigItem(14, 'iMinPasswordChange', 'number', '4', gettext("Minimum amount that a new password must differ from the old one (# of characters changed)\nSet to zero to disable this feature")),
             'aDisallowedPasswords'                 => new ConfigItem(15, 'aDisallowedPasswords', 'text', 'password,god,jesus,church,christian', gettext('A comma-separated list of disallowed (too obvious) passwords.')),
@@ -274,7 +273,7 @@ private static function buildCategories(): array
             gettext('Church Services')    => ['iPersonConfessionFatherCustomField', 'iPersonConfessionDateCustomField'],
             gettext('Backup')             => ['sLastBackupTimeStamp', 'bEnableExternalBackupTarget', 'sExternalBackupType', 'sExternalBackupAutoInterval', 'sExternalBackupEndpoint', 'sExternalBackupUsername', 'sExternalBackupPassword'],
             gettext('Two-Factor Authentication') => ['bEnable2FA', 'bRequire2FA', 's2FAApplicationName', 'sTwoFASecretKey'],
-            gettext('System Settings')    => ['sLogLevel', 'bCSVAdminOnly', 'bEnforceCSP', 'bHSTSEnable', 'iDashboardServiceIntervalTime', 'bAllowPrereleaseUpgrade'],
+            gettext('System Settings')    => ['sLogLevel', 'bEnforceCSP', 'bHSTSEnable', 'iDashboardServiceIntervalTime', 'bAllowPrereleaseUpgrade'],
         ];
     }
 

src/ChurchCRM/model/ChurchCRM/User.php

@@ -190,16 +190,6 @@ public function isAddEvent(): bool
         return $this->isAdmin() || $this->isEnabledSecurity('bAddEvent');
     }
 
-    public function isCSVExportEnabled(): bool
-    {
-        return $this->isCSVExport();
-    }
-
-    public function isCSVExport(): bool
-    {
-        return $this->isAdmin() || $this->isEnabledSecurity('bExportCSV');
-    }
-
     public function isEmailEnabled(): bool
     {
         return $this->isAdmin() || $this->isEnabledSecurity('bEmailMailto');

src/FinancialReports.php

@@ -326,10 +326,8 @@
         echo '<td class=TextColumnWithBottomBorder><input name=RequireDonationYears type=text value=0 size=5></td></tr>';
     }
 
-    if (
-        ((AuthenticationManager::getCurrentUser()->isAdmin() && $bCSVAdminOnly) || !$bCSVAdminOnly)
-        && (in_array($sReportType, ['Pledge Summary', 'Giving Report', 'Individual Deposit Report', 'Advanced Deposit Report', 'Zero Givers']))
-    ) {
+    // Show CSV output option for reports that support it
+    if (in_array($sReportType, ['Pledge Summary', 'Giving Report', 'Individual Deposit Report', 'Advanced Deposit Report', 'Zero Givers'])) {
         echo '<tr><td class=LabelColumn>' . gettext('Output Method:') . '</td>';
         echo "<td class=TextColumnWithBottomBorder><input name=output type=radio checked value='pdf'>PDF";
         echo " <input name=output type=radio value='csv'>" . gettext('CSV') . '</tr>';

src/ReminderReport.php

@@ -4,14 +4,11 @@
 require_once __DIR__ . '/Include/Functions.php';
 
 use ChurchCRM\Authentication\AuthenticationManager;
-use ChurchCRM\dto\SystemConfig;
 use ChurchCRM\Utils\InputUtils;
 use ChurchCRM\Utils\RedirectUtils;
 
-// If CSVAdminOnly option is enabled and user is not admin, redirect to the menu.
-if (!AuthenticationManager::getCurrentUser()->isAdmin() && SystemConfig::getValue('bCSVAdminOnly')) {
-    RedirectUtils::securityRedirect('Admin');
-}
+// Security
+AuthenticationManager::redirectHomeIfFalse(AuthenticationManager::getCurrentUser()->isFinanceEnabled(), 'Finance');
 
 $sPageTitle = gettext('Pledge Reminder Report');
 require_once __DIR__ . '/Include/Header.php';

src/Reports/AdvancedDeposit.php

@@ -7,10 +7,9 @@
 
 use ChurchCRM\Authentication\AuthenticationManager;
 use ChurchCRM\dto\SystemConfig;
+use ChurchCRM\Service\FinancialService;
 use ChurchCRM\Utils\CsvExporter;
 use ChurchCRM\Utils\InputUtils;
-use ChurchCRM\Utils\RedirectUtils;
-use ChurchCRM\Service\FinancialService;
 
 // Security
 AuthenticationManager::redirectHomeIfFalse(AuthenticationManager::getCurrentUser()->isFinanceEnabled(), 'Finance');
@@ -62,11 +61,6 @@
     $output = 'pdf';
 }
 
-// If CSVAdminOnly option is enabled and user is not admin, redirect to the menu.
-if (!AuthenticationManager::getCurrentUser()->isAdmin() && SystemConfig::getValue('bCSVAdminOnly') && $output != 'pdf') {
-    RedirectUtils::securityRedirect('Admin');
-}
-
 // Normalize date range
 $today = date('Y-m-d');
 if (!$sDateEnd && $sDateStart) {

src/Reports/EnvelopeReport.php

@@ -9,12 +9,9 @@
 use ChurchCRM\dto\SystemConfig;
 use ChurchCRM\model\ChurchCRM\Family;
 use ChurchCRM\model\ChurchCRM\FamilyQuery;
-use ChurchCRM\Utils\RedirectUtils;
 
-// If CSVAdminOnly option is enabled and user is not admin, redirect to the menu
-if (!AuthenticationManager::getCurrentUser()->isAdmin() && SystemConfig::getValue('bCSVAdminOnly')) {
-    RedirectUtils::securityRedirect('Admin');
-}
+// Security
+AuthenticationManager::redirectHomeIfFalse(AuthenticationManager::getCurrentUser()->isFinanceEnabled(), 'Finance');
 
 class PdfEnvelopeReport extends ChurchInfoReport
 {

src/Reports/FamilyPledgeSummary.php

@@ -9,7 +9,6 @@
 use ChurchCRM\dto\SystemConfig;
 use ChurchCRM\Utils\FiscalYearUtils;
 use ChurchCRM\Utils\InputUtils;
-use ChurchCRM\Utils\RedirectUtils;
 
 // Security
 AuthenticationManager::redirectHomeIfFalse(AuthenticationManager::getCurrentUser()->isFinanceEnabled(), 'Finance');
@@ -62,11 +61,6 @@
     $only_owe = InputUtils::legacyFilterInput($_POST['only_owe']);
 }
 
-// If CSVAdminOnly option is enabled and user is not admin, redirect to the menu.
-if (!AuthenticationManager::getCurrentUser()->isAdmin() && SystemConfig::getValue('bCSVAdminOnly')) {
-    RedirectUtils::securityRedirect('Admin');
-}
-
 // Get all the families
 $sSQL = 'SELECT DISTINCT fam_ID, fam_Name FROM family_fam';
 

src/Reports/PledgeSummary.php

@@ -10,7 +10,6 @@
 use ChurchCRM\Utils\CsvExporter;
 use ChurchCRM\Utils\FiscalYearUtils;
 use ChurchCRM\Utils\InputUtils;
-use ChurchCRM\Utils\RedirectUtils;
 
 // Security
 AuthenticationManager::redirectHomeIfFalse(AuthenticationManager::getCurrentUser()->isFinanceEnabled(), 'Finance');
@@ -24,11 +23,6 @@
 // Remember the chosen Fiscal Year ID
 $_SESSION['idefaultFY'] = $iFYID;
 
-// If CSVAdminOnly option is enabled and user is not admin, redirect to the menu.
-if (!AuthenticationManager::getCurrentUser()->isAdmin() && SystemConfig::getValue('bCSVAdminOnly') && $output !== 'pdf') {
-    RedirectUtils::securityRedirect('Admin');
-}
-
 // Get the list of funds
 $sSQL = "SELECT fun_ID,fun_Name,fun_Description,fun_Active FROM donationfund_fun WHERE fun_Active = 'true' ORDER BY fun_Active, fun_Name";
 $rsFunds = RunQuery($sSQL);

src/Reports/PrintDeposit.php

@@ -7,7 +7,6 @@
 use ChurchCRM\model\ChurchCRM\PledgeQuery;
 
 use ChurchCRM\Authentication\AuthenticationManager;
-use ChurchCRM\dto\SystemConfig;
 use ChurchCRM\dto\SystemURLs;
 use ChurchCRM\Utils\InputUtils;
 use ChurchCRM\Utils\RedirectUtils;
@@ -42,11 +41,6 @@
     RedirectUtils::redirect('v2/dashboard');
 }
 
-// If CSVAdminOnly option is enabled and user is not admin, redirect to access denied.
-if (!AuthenticationManager::getCurrentUser()->isAdmin() && SystemConfig::getValue('bCSVAdminOnly') && $output != 'pdf') {
-    RedirectUtils::securityRedirect('Admin');
-}
-
 if ($output === 'pdf') {
     // Server-side guard: if this deposit has no payments, show a friendly message instead of redirecting
     $paymentsCount = PledgeQuery::create()->filterByDepId($iDepositSlipID)->count();