Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lyric Search Enhancement #501

Closed
jzongker opened this issue May 10, 2024 · 0 comments
Closed

Lyric Search Enhancement #501

jzongker opened this issue May 10, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@jzongker
Copy link
Contributor

When searching for lyrics, the Genuis.com API is lacking a number of classic hymns. I suggest the following:

  1. Clicking search will asynchronously make calls to both Genuis and Hymnary.org, with the possibility of this including other sources like SongSelect in the future.
  2. Show search results with song title, source and the first line of text rather than immediately populating the lyrics with the first result.
  3. Populate the lyrics when the user selects a song from the search results.
@jzongker jzongker added the enhancement New feature or request label May 10, 2024
@jzongker jzongker self-assigned this May 10, 2024
vassbo pushed a commit that referenced this issue Jun 12, 2024
* Show search results

* Select songs from search results

* Added hymnary

* Updated toast message and added error handling.
@vassbo vassbo closed this as completed Jun 12, 2024
vassbo added a commit that referenced this issue Jun 26, 2024
* 🚩 Updated languages

* ✨ Optimization
- Consistent saving
- Better organization & naming
- Better startup
- Playlist names decoded

* 🎨 Custom border radius
- Fixed some freeze errors
- Tweaked settings

* ⏱ Metronome

* ✨ Start metronome from slide
- Drop actions to slide
- Fixed new items getting removed if not in selected template
- Special textboxes are removed when changing template
- Text editor will select the best textbox
- List view textboxes in correct oreder
- Text editor not removing extra items

* Issue #501 Fix (#576)

* Show search results

* Select songs from search results

* Added hymnary

* Updated toast message and added error handling.

* 🔍 Added Svelte inspector

* Optimized media (#586)

* 🖼 New handling of thumbnails
- New virtual grid

* 🖼 Enhancements
- Fixed jpg thumbnails
- Fixed media loader
- Less lag when scrolling

* ✔ Removed unused code

* ✨ Improved media loading
- Slide & stage cache working with the new system
- Removed old mediaCache

* 🖼 Changed from ffmpeg to custom capturer

* 🖼 Faster Media Thumbnails
- Fixed gif, webp & mov not working
- Uppercase filenames working
- Editor thumbnails

* ✔ Fixed receivers

* ✔ Improved OpenLP parser
- Fixed OpenLP songs sometimes not arranged after order
- Fixed API Bible not loading
- Updated Show search style

* Add more checks on whether the note is correct (#591)

* ✨ Optimizations
- Removed Svelte inspector from prod
- Organized code
- Preload script map

* 📦 SoftProjector importing

* ✔ Lots of bugfixes
- Fixed timer becoming imprecise
- Fixed timer not starting when "Start show" action was triggered
- Fixed output not always getting data
- Fixed empty action not removed
- Fixed Cloud syncing on save and not close
- Better sync indication
- Stage align & CSS edit
- Fixed an error with video transition
- Media item thumbnail
- Fixed cut in two not working when having multiple textboxes
- Media select outline
- Align with screen trigger
- Toggle to allow  output on main screen
- Removed some special VideoPsalm tags
- Scripture content search has more results

* Custom linux arm64 build (#602)

* 📦 Custom Linux arm64 build

* Updated checkout to v3 & node to 20

* ✔ Removed capture window to remove save dialog sometimes

* ✨ Template slide values
- Template background & overlay
- Custom first slide template
- Scripture auto scroll
- Fixed playing audio title
- OpenLyrics multiple lines tag support
- Video volume working again
- Change video gain
- Improved clearing per output
- Window miminum size
- Better preview fps
- Fixed freeze when slide background was not found
- Fixed loop sometimes when setting template
- Set video in styles

* ✨ Template actions
- Template add overlays
- Fixed background sometimes not pausing
- Custom action activation
- Scripture verses on individual lines
- Fixed empty scripture preview
- Export/import themes & templates
- Updated import popup
- Reduced import image sizes

* Making test to be independent from what was on the existing setup (#605)

* Now execute with bash cmd: FS_MOCK_STORE_PATH=/var/folders/xq/hbb976490kjf8s2lxkj0c3xh0000gn/T/tmp.WBSw8XuU8h bash -c 'npm run test && rm -rf '

* Add timeout to actions

* Add a screenshot around assert

* Update start.test.ts

* improve test

* make alert ack optional

* make npm run test to use tmp dir

* Delete test-output/screenshots/failed.png

* Update .gitignore to ignore test output dirs

* the test should finally be quite stable, and not depends on existing setup

* cleaning up minor issues and refactor a little bit

* remove unnessary data-testid

* fix var naming convension

* 🚩 Updated languages

* 🔗 Updated repo paths

* Add playwright config and github worklow to run e2e test (#606)

* add playwright config and github worklow to run e2e test

* Add dev branch E2E test status to README.md

* Update README.md

* 🔊 Audio crossfade
- Mute audio when video is playing
- Next playlist track action
- Start action on video start/end
- Changed schedule show to schedule action in calendar

* 🎵 Fixed slide play MIDI

* 📝 Live captions
- Better shows search
- Shows loading if not loaded when MIDI triggered
- Precise timer interval
- Drop media on template
- Fixed scripture issues

* ✨ Variable dynamic values
- Fixed Remote issues
- Fixed chords when line break
- Enable/disable actions
- Toggle actions action
- Scripture reference align

* ✨ UI enhancements
- Group templates
- Slide template can update without a show template
- You can now delete files synced to drive
- Fixed caret resetting when line is removed
- Bug fixes

* ✔ Fixed Lessons.church
- Tweaked media cache
- Fade out video audio

* Version update

---------

Co-authored-by: Jeremy Zongker <[email protected]>
Co-authored-by: Daniel Ip <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants