Removed unnecessary IEnumerable materialization

Author: glen-84

src/HotChocolate/Fusion-vnext/src/Fusion.Composition/PreMergeValidation/Rules/ExternalArgumentDefaultMismatchRule.cs

@@ -20,11 +20,7 @@ public void Handle(OutputFieldGroupEvent @event, CompositionContext context)
     {
         var (fieldName, fieldGroup, typeName) = @event;
 
-        var externalFields = fieldGroup
-            .Where(i => i.Field.HasExternalDirective())
-            .ToImmutableArray();
-
-        if (externalFields.Length == 0)
+        if (!fieldGroup.Any(i => i.Field.HasExternalDirective()))
         {
             return;
         }

src/HotChocolate/Fusion-vnext/src/Fusion.Composition/SourceSchemaMerger.cs

@@ -196,8 +196,7 @@ private EnumTypeDefinition MergeEnumTypes(ImmutableArray<TypeInfo> typeGroup)
             .SelectMany(
                 i => ((EnumTypeDefinition)i.Type).Values,
                 (i, v) => new EnumValueInfo(v, (EnumTypeDefinition)i.Type, i.Schema))
-            .GroupBy(i => i.EnumValue.Name)
-            .ToImmutableArray();
+            .GroupBy(i => i.EnumValue.Name);
 
         foreach (var grouping in enumValueGroupByName)
         {
@@ -252,8 +251,7 @@ private InputObjectTypeDefinition MergeInputTypes(ImmutableArray<TypeInfo> typeG
                 (i, f) => new InputFieldInfo(f, (InputObjectTypeDefinition)i.Type, i.Schema))
             .GroupBy(i => i.Field.Name)
             // Intersection: Field definition count matches type definition count.
-            .Where(g => g.Count() == typeGroup.Length)
-            .ToImmutableArray();
+            .Where(g => g.Count() == typeGroup.Length);
 
         foreach (var grouping in fieldGroupByName)
         {
@@ -341,8 +339,7 @@ private InterfaceTypeDefinition MergeInterfaceTypes(ImmutableArray<TypeInfo> typ
             .SelectMany(
                 i => ((InterfaceTypeDefinition)i.Type).Fields,
                 (i, f) => new OutputFieldInfo(f, (ComplexTypeDefinition)i.Type, i.Schema))
-            .GroupBy(i => i.Field.Name)
-            .ToImmutableArray();
+            .GroupBy(i => i.Field.Name);
 
         foreach (var grouping in fieldGroupByName)
         {
@@ -404,8 +401,7 @@ private InterfaceTypeDefinition MergeInterfaceTypes(ImmutableArray<TypeInfo> typ
             .SelectMany(
                 i => ((ObjectTypeDefinition)i.Type).Fields,
                 (i, f) => new OutputFieldInfo(f, (ComplexTypeDefinition)i.Type, i.Schema))
-            .GroupBy(i => i.Field.Name)
-            .ToImmutableArray();
+            .GroupBy(i => i.Field.Name);
 
         foreach (var grouping in fieldGroupByName)
         {
@@ -470,8 +466,7 @@ private InterfaceTypeDefinition MergeInterfaceTypes(ImmutableArray<TypeInfo> typ
             .Where(i => !i.Argument.HasRequireDirective())
             .GroupBy(i => i.Argument.Name)
             // Intersection: Argument definition count matches field definition count.
-            .Where(g => g.Count() == fieldGroup.Length)
-            .ToImmutableArray();
+            .Where(g => g.Count() == fieldGroup.Length);
 
         foreach (var grouping in argumentGroupByName)
         {

src/HotChocolate/Fusion-vnext/src/Fusion.Composition/SourceSchemaValidation/Rules/ExternalUnusedRule.cs

@@ -1,4 +1,3 @@
-using System.Collections.Immutable;
 using HotChocolate.Fusion.Events;
 using HotChocolate.Fusion.Extensions;
 using HotChocolate.Skimmed;
@@ -25,8 +24,7 @@ public void Handle(OutputFieldEvent @event, CompositionContext context)
                 schema.Types
                     .OfType<ComplexTypeDefinition>()
                     .SelectMany(t => t.Fields)
-                    .Where(f => f.Type == type)
-                    .ToImmutableArray();
+                    .Where(f => f.Type == type);
 
             var isReferenced =
                 referencingFields.Any(f => ValidationHelper.ProvidesFieldName(f, field.Name));

src/HotChocolate/Fusion-vnext/src/Fusion.Composition/SourceSchemaValidator.cs

@@ -96,10 +96,7 @@ private void PublishEntityEvents(
         SchemaDefinition schema,
         CompositionContext context)
     {
-        var keyDirectives =
-            entityType.Directives
-                .Where(d => d.Name == DirectiveNames.Key)
-                .ToArray();
+        var keyDirectives = entityType.Directives.Where(d => d.Name == DirectiveNames.Key);
 
         foreach (var keyDirective in keyDirectives)
         {