-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] wallet update states and subscribes to a HUGE number of already spent coins on restart #17013
Comments
We are planning to improve how the lite wallet syncs if it has existing state and has a trusted node. |
Does it mean that a wallet can not be sure that the coin reported as spent is actually spent based on the information provided by the node and this is why it resyncs all the coins states every time it restarts? Why it removes CLAWBACK coins from the list of interested coins then? |
The last time wallet took more than an hour to start. The increase in time is caused by high network load due to dust storm but the root cause is very very inefficient wallet bootstrap procedure. Is there any simple solution you can suggest? How should I patch the code not to broke it and get rid of these massive spent coins synchronization? |
This issue has not been updated in 14 days and is now flagged as stale. If this issue is still affecting you and in need of further review, please comment on it with an update to keep it from auto closing in 7 days. |
Hey! The issue is very actual |
@wjblanke can we expect performance improvements in the nearest months? In the next release. |
This issue has not been updated in 14 days and is now flagged as stale. If this issue is still affecting you and in need of further review, please comment on it with an update to keep it from auto closing in 7 days. |
Running a local node (which is thus trusted) will speed up the wallet syncing process, since coins will not need to be validated. We are working on lite wallet improvements for remote untrusted nodes. |
Every transfer a wallet made adds a coin into the |
Thanks we will look into this |
the fundamental problem is that the wallet doesn't remember how far we synced the wallet in the last session. Every time we start the wallet we sync from scratch. This is something we're working towards fixing with an improved wallet protocol. |
We are working on a new wallet protocol that will support this. We may have a branch soon, here is the work in progress This is being discussed in this CHIP And there is this community effort as well |
I suspect that the problem with ever growing |
You could try main with the above "use_delta_sync" option. |
use_delta_sync is in 2.3.0 as well |
The new wallet protocol is implemented but wallet has not been updated yet |
What happened?
The wallet is very active but only has 2-6 unspent coins now.
The restart takes ~20 minutes and there are following lines in the log:
It seams that coins comes from the
interested_coins
table which has 115556 records now and there is only one place in the code where these coins are removed:chia-blockchain/chia/wallet/wallet_state_manager.py
Lines 1842 to 1843 in 6c8259c
But what about normal coins? What about rewards? Why the wallet is interested in already spent coins and takes forever to restart? This doesn't seems right.
Any suggestions?
Version
2.1.1
What platform are you using?
Linux
What ui mode are you using?
CLI
Relevant log output
No response
The text was updated successfully, but these errors were encountered: