Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the concept of Block to the paddedBytes for more clarity #468

Open
nazarhussain opened this issue Mar 5, 2025 · 0 comments
Open

Rename the concept of Block to the paddedBytes for more clarity #468

nazarhussain opened this issue Mar 5, 2025 · 0 comments

Comments

@nazarhussain
Copy link
Contributor

nazarhussain commented Mar 5, 2025 •
edited
Loading

Is your feature request related to a problem? Please describe.

Not a problem but more logical understanding of the code. During a PR review it's discussed that Block meant a different understanding in our domain. In our code base it's represents the chunks of 64 bytes used by the SHA256 for hashing.

Describe the solution you'd like

Would be really nice to rename this concept to paddedBytes which will be easy to understand.

Additional context

#409 (comment)
@nazarhussain nazarhussain changed the title @matthewkeil I am in favor of renaming this function to getPaddedBytes64. But I feel it should be done separately across the repo. Rename the concept of Block to the paddedBytes for more clarity Mar 5, 2025
@nazarhussain nazarhussain mentioned this issue Mar 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nazarhussain