Move spec constants to global scope to use CONSTANT_CASE

Author: nazarhussain

packages/persistent-merkle-tree/test/perf/tree.test.ts

@@ -10,10 +10,11 @@ import {
   uint8ArrayToHashObject,
 } from "../../src/index.js";
 
+const VALIDATOR_REGISTRY_LIMIT = 1099511627776;
+
 describe("Track the performance of different Tree methods", () => {
-  const validatorRegistryLimit = 1099511627776;
   // add 1 to countToDepth for mix_in_length spec
-  const depth = countToDepth(BigInt(Math.ceil(validatorRegistryLimit / 4))) + 1;
+  const depth = countToDepth(BigInt(Math.ceil(VALIDATOR_REGISTRY_LIMIT / 4))) + 1;
 
   const newRoot = new Uint8Array(Array.from({length: 32}, () => 1));
   const numBalance = 250_000;

packages/persistent-merkle-tree/test/unit/packedNode.test.ts

@@ -7,6 +7,8 @@ import {
   packedUintNum64sToLeafNodes,
 } from "../../src/packedNode.js";
 
+const NUMBER_2_POW_32 = 2 ** 32;
+
 describe("subtree / packedNode single node", () => {
   const testCases: {
     id: string;
@@ -200,7 +202,6 @@ describe("subtree / packedNode single node", () => {
 
     // 1 UintNum64 = 8 bytes
     if (testPackedNumbers) {
-      const number2Pow32 = 2 ** 32;
       it(`${id} - packedUintNum64sToLeafNodes, value size=${Math.floor(size / 8)}`, () => {
         const values: number[] = [];
         const uint8Array = new Uint8Array(Buffer.from(outStr.replace("0x", ""), "hex"));
@@ -211,7 +212,7 @@ describe("subtree / packedNode single node", () => {
           if (a === 0xffffffff && b === 0xffffffff) {
             values.push(Infinity);
           } else {
-            values.push(b * number2Pow32 + a);
+            values.push(b * NUMBER_2_POW_32 + a);
           }
         }
 

packages/ssz/test/perf/bitlist.test.ts

@@ -1,13 +1,14 @@
 import {bench, describe} from "@chainsafe/benchmark";
 import {BitArray, BitListType} from "../../src/index.js";
 
+const MAX_VALIDATORS_PER_COMMITTEE = 2048;
+
 // running zipIndexesCommitteeBits() on `bitLen: 2048, bitsSet: 2048` takes 50.904 us/op
 // However deserializing a BitList to struct `len 2048, set 2048` takes 560.4670 us/op,
 // so it's far more efficient to keep bitlists as Uint8Arrays and also save memory.
 
 describe("BitListType types", () => {
-  const maxValidatorsPerCommittee = 2048;
-  const CommitteeBits = new BitListType(maxValidatorsPerCommittee);
+  const CommitteeBits = new BitListType(MAX_VALIDATORS_PER_COMMITTEE);
 
   const testCases: {bitLen: number; bitsSet: number}[] = [
     // Realistic mainnet case

packages/ssz/test/perf/iterate.test.ts

@@ -2,6 +2,8 @@ import {bench, describe, setBenchOpts} from "@chainsafe/benchmark";
 import {ListBasicType, UintNumberType} from "../../src/index.js";
 import {Validators} from "../lodestarTypes/phase0/sszTypes.js";
 
+const VALIDATOR_REGISTRY_LIMIT = 1099511627776;
+
 describe("iterate", () => {
   setBenchOpts({noThreshold: true});
 
@@ -55,9 +57,7 @@ describe("readonly values - iterator vs array", () => {
 });
 
 function createBalanceList(count: number) {
-  const validatorRegistryLimit = 1099511627776;
-
-  const balancesList = new ListBasicType(new UintNumberType(8), validatorRegistryLimit);
+  const balancesList = new ListBasicType(new UintNumberType(8), VALIDATOR_REGISTRY_LIMIT);
   const balancesStruct = Array.from({length: count}, () => 31217089836);
   return balancesList.toViewDU(balancesStruct);
 }

packages/ssz/test/perf/list.test.ts

@@ -2,6 +2,8 @@ import {bench, describe} from "@chainsafe/benchmark";
 import {LeafNode, Node, subtreeFillToContents} from "@chainsafe/persistent-merkle-tree";
 import {ListBasicType, UintNumberType} from "../../src/index.js";
 
+const VALIDATOR_REGISTRY_LIMIT = 1099511627776;
+
 describe("list", () => {
   const numBalances = 250_000;
 
@@ -83,9 +85,7 @@ describe("subtreeFillToContents", () => {
 });
 
 function createBalanceList(count: number) {
-  const validatorRegistryLimit = 1099511627776;
-
-  const balancesList = new ListBasicType(new UintNumberType(8), validatorRegistryLimit);
+  const balancesList = new ListBasicType(new UintNumberType(8), VALIDATOR_REGISTRY_LIMIT);
   const balancesStruct = Array.from({length: count}, () => 31217089836);
   const viewDU = balancesList.toViewDU(balancesStruct);
   // Prime cache

packages/ssz/test/perf/stateTransitionOps/processAttestations.test.ts

@@ -2,15 +2,15 @@ import {beforeAll, bench, describe} from "@chainsafe/benchmark";
 import {MutableVector} from "@chainsafe/persistent-ts";
 import {CompositeViewDU, ListBasicType, UintNumberType} from "../../../src/index.js";
 
+const VALIDATOR_REGISTRY_LIMIT = 1099511627776;
+
 describe("processAttestations", () => {
   const vc = 250_000;
   const attesterShare = 32;
   const attesterIndices: number[] = [];
   const statusArr: number[] = [];
-
-  const validatorRegistryLimit = 1099511627776;
   const uint8Type = new UintNumberType(1);
-  const epochStatusesType = new ListBasicType(uint8Type, validatorRegistryLimit);
+  const epochStatusesType = new ListBasicType(uint8Type, VALIDATOR_REGISTRY_LIMIT);
 
   // Helper types
   type Statuses = typeof epochStatusesType;

packages/ssz/test/unit/eth2/validators.test.ts

@@ -2,6 +2,8 @@ import {describe, expect, it, vi} from "vitest";
 import {CompositeViewDU, ListCompositeType, ValueOf, toHexString} from "../../../src/index.js";
 import {ValidatorContainer, ValidatorNodeStruct} from "../../lodestarTypes/phase0/sszTypes.js";
 
+const VALIDATOR_REGISTRY_LIMIT = 1099511627776;
+
 type Validator = ValueOf<typeof ValidatorContainer>;
 const validator: Validator = {
   pubkey: Buffer.alloc(48, 0xaa),
@@ -56,8 +58,7 @@ describe("Container with BranchNodeStruct", () => {
   }
 
   describe("ValidatorNodeStruct in List", () => {
-    const validatorRegistryLimit = 1099511627776;
-    const ValidatorsListType = new ListCompositeType(ValidatorNodeStruct, validatorRegistryLimit);
+    const ValidatorsListType = new ListCompositeType(ValidatorNodeStruct, VALIDATOR_REGISTRY_LIMIT);
 
     it("edit then read", () => {
       const validatorListTB = ValidatorsListType.defaultViewDU();

packages/ssz/test/unit/regressions.test.ts

@@ -14,6 +14,7 @@ import {
 } from "../../src/index.js";
 import {uint32NumType, uint64NumType} from "../utils/primitiveTypes.js";
 
+const VALIDATOR_REGISTRY_LIMIT = 1099511627776;
 // Compilation of various issues from SSZ and Lodestar libs
 
 describe("Regressions / known issues", () => {
@@ -75,8 +76,7 @@ describe("Regressions / known issues", () => {
       validatorIndexes.push(i);
     }
 
-    const validatorRegistryLimit = 1099511627776;
-    const type = new ListBasicType(uint64NumType, validatorRegistryLimit);
+    const type = new ListBasicType(uint64NumType, VALIDATOR_REGISTRY_LIMIT);
     // This is the logic to calculate activeIndexRoots in processFinalUpdates
     const hash = Buffer.from(type.hashTreeRoot(validatorIndexes)).toString("hex");
     expect(hash).to.equal("ba1031ba1a5daab0d49597cfa8664ce2b4c9b4db6ca69fbef51e0a9a325a3b63");