Skip to content

Dependency on npm electron binary package causes build failure on Life and DogeOS Android bases (armv7l) #7527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tallero opened this issue Mar 4, 2025 · 0 comments
Labels
meta-bug Issues that identify a bug and require a fix.

Comments

@tallero
Copy link

tallero commented Mar 4, 2025

Describe the bug

Hello,

it seems Lodestar's dependency on electron nodejs/npm binary package causes build failure on Life and DogeoOS Android bases (ARMv7).
Indeed I have a working electron binary build in the repositories for this architecture so I guess as for c-zkg there is to downstream fork the dependency, fix it, install it locally and patch Lodestar to use that instead of the upstream, or either somehow convince its maintainers to add an Electron Android ARMv7 binary to their npm package.

Well, since also [I'm experiencing this one issue on the DogeOS GNU base (x86_64)] I guess testing the validator machinery will probably be postponed again as it seems at least one or two days of work.

Oh btw, how exactly Lodestar developers see the program packaged?
I've seen there's a build:bundle command which I'm not exactly sure what it should produce.

I suspect same as with c-kzg I won't be able to install the tgz resulting from npm pack because that will cause npm to try to rebuild every dependency, so failing to find the local ones. That library though has a make bundle script which produces a dist directory which actually is the c-kzg module directory to be added to node_modules.

So, am I supposed to do the same for lodestar? Copy over to global node_modules the project source directory in which the yarn install and run build have been run and move the binary to /usr/bin?

Expected behavior

It should build.

Steps to reproduce

I'm building the program on DogeOS Android base (armv7l) using the reallymakepkg command on the Ur universal build recipe for lodestar found at [nodejs-lodestar-ur](https://github.com/themartiancompany/nodejs-lodestar-ur].

Additional context

error /data/data/com.termux/files/home/nodejs-lodestar-build/src/lodestar-c8e2203c59526a50768757535068d97db1614c66/node_modules/electron: Command failed.
Exit code: 1
Command: node install.js
Arguments: 
Directory: /data/data/com.termux/files/home/nodejs-lodestar-build/src/lodestar-c8e2203c59526a50768757535068d97db1614c66/node_modules/electron
Output:
/data/data/com.termux/files/home/nodejs-lodestar-build/src/lodestar-c8e2203c59526a50768757535068d97db1614c66/node_modules/electron/install.js:105
      throw new Error('Electron builds are not available on platform: ' + platform);
      ^

Error: Electron builds are not available on platform: android
    at getPlatformPath (/data/data/com.termux/files/home/nodejs-lodestar-build/src/lodestar-c8e2203c59526a50768757535068d97db1614c66/node_modules/electron/install.js:105:13)
    at Object.<anonymous> (/data/data/com.termux/files/home/nodejs-lodestar-build/src/lodestar-c8e2203c59526a50768757535068d97db1614c66/node_modules/electron/install.js:16:22)
    at Module._compile (node:internal/modules/cjs/loader:1554:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1706:10)
    at Module.load (node:internal/modules/cjs/loader:1289:32)
    at Module._load (node:internal/modules/cjs/loader:1108:12)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:220:24)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:170:5)

Operating system

Life Android base (armv7l)
DogeOS Android base (armv7l)

Lodestar version or commit hash

v1.27.1

@tallero tallero added the meta-bug Issues that identify a bug and require a fix. label Mar 4, 2025
@tallero tallero changed the title Dependency on an npm electron binary package causes build failure on Life and DogeOS Android bases (armv7l) Dependency on npm electron binary package causes build failure on Life and DogeOS Android bases (armv7l) Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-bug Issues that identify a bug and require a fix.
Projects
None yet
Development

No branches or pull requests

1 participant