Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off vertical exaggeration for some Models in the Scene #11940

Open
jjhembd opened this issue Apr 17, 2024 · 4 comments
Open

Turn off vertical exaggeration for some Models in the Scene #11940

jjhembd opened this issue Apr 17, 2024 · 4 comments

Comments

@jjhembd
Copy link
Contributor

jjhembd commented Apr 17, 2024

Feature

As reported by @Jean-Dum in #11936: Scene.verticalExaggeration exaggerates every Model on the screen:
image

Some users may want to show exaggerated terrain, but leave some models unscaled. This was the behavior of the old Globe.terrainExaggeration which has been removed since v1.116.

@Jean-Dum can you add some context about your use case for exaggerating only part of the scene? This will help us prioritize the issue.

@Jean-Dum
Copy link

Thank you for openning this issue @jjhembd
I don't really know which solution would be the best to let the user choose on which object to apply verticalExaggeration, but it could be one of those options:

  • Split behaviours between two different values (for example terrainExaggeration and modelsExaggeration)
  • Allow the user to deactivate verticalExagerration for a given datasource (add an option disableVerticalExaggeration to CustomDataSource)
  • Allow the user to deactivate verticalExaggeration for a given model (add an option disableVerticalExaggeration to ModelGraphics)

Maybe there is another solution which could be better for everyone!

@syzdev
Copy link
Contributor

syzdev commented May 7, 2024

Hi @jjhembd , setting exaggerated parameters for different models is an important feature. Is there a plan for the next step in addressing this issue?

@ggetz
Copy link
Contributor

ggetz commented May 9, 2024

Hi @syzdev, we don't have a planned date for this yet

If you'd like to add more information about your use case, that may help us prioritize. If you are interesting in contributing, please let us know and we'd be happy to discuss implementation or review a PR. Thanks!

@syzdev
Copy link
Contributor

syzdev commented May 10, 2024

@ggetz I strongly agree with the several optimization solutions listed by @Jean-Dum . Overall, there are not many use cases for this feature. In limited use cases, most users should hope that the behavior of the model and terrain should be separated. However, further, users hope to independently control the exaggeration of each model. For example, in geological analysis use cases, users want to only exaggerate the geological model while keeping other building models above the geological model unchanged.

Of course, these suggestions will cause significant changes to the feature itself, and I am also very curious about what other users use cases are. I believe that more users need to participate in the discussion regarding this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants