Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async version of Resource Proxy getURL #11935

Open
charlesritchea opened this issue Apr 15, 2024 · 3 comments
Open

async version of Resource Proxy getURL #11935

charlesritchea opened this issue Apr 15, 2024 · 3 comments

Comments

@charlesritchea
Copy link

Feature

As everyone should know AWS SDK v2 is going away and we should all move to v3

In our implementation of Cesium/Resource/Proxy.getURL we use the v2 aws sdk

s3.getSignedUrl('getObject', {
        Bucket: s3Object.bucket,
        Key: s3Object.key,
        Expires: 86400 // 24 hours
})

In v2, this is a synchronous method and works in getURL.
However in v3, The only solution I could find is async.

Can you make getURL async? Or is there an alternative to this class?

@ggetz
Copy link
Contributor

ggetz commented Apr 16, 2024

Hi @charlesritchea, using a promise within getUrl is not currently supported. Though I would say this is related to some cleanup we'd like to do for the entire Resource class to make better use of async code paths.

@charlesritchea
Copy link
Author

Yes, that's why this is a feature request. :) Glad to see it's being considered, but wanted to let you know this is forcing people to use the abandoned sdk

@ggetz
Copy link
Contributor

ggetz commented Apr 16, 2024

Got it, thanks @charlesritchea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants